1577592 - Shadow Parts seem to not match ::part when a document fragment with [part] elements inside of it is imported into a shadow root

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Brian Grinstead [:bgrins]]

Details here: https://phabricator.services.mozilla.com/D43846#1324342.

When I remove and re-add the [part] attribute, the selector starts matching again.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Any chance you could write a stand-alone test-case? Happy to fix ASAP :)

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: working-content-testcase.html

This was my first attempt to have a reduced test case in content but it is working properly. I guess a couple more things to test are loading this same thing but with the style in an external chrome sheet and then also using XUL elements instead.

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Bug 1577592 - Test case for Shadow Parts not applying with fragment containing XUL element

Comment 4

[Brian Grinstead [:bgrins]]

It seems somehow XUL and/or XBL related - I've pushed up a more reduced mochitest-chrome test that fails.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Thanks, I'll take a look first thing tomorrow morning :)

Comment 6

[Emilio Cobos Álvarez (:emilio)]

I actually just took a look, whoops... It's indeed a XUL bug.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1577592 - Properly set the has part attribute bit when cloning a XUL element.

Test is in the other revision for this bug.

Do the same we do for the other bits. This setup looks pretty error prone
though...

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b78fd9e42adc
Properly set the has part attribute bit when cloning a XUL element. r=bzbarsky

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a334d3b33b26
Test case for Shadow Parts not applying with fragment containing XUL element r=emilio

Comment 10

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b78fd9e42adc
https://hg.mozilla.org/mozilla-central/rev/a334d3b33b26

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b78fd9e42adc
https://hg.mozilla.org/releases/mozilla-beta/rev/a334d3b33b26