15776 - Compilation errors with some gcc versions

Status: VERIFIED FIXED

(Core :: XUL, defect, P1)

Description

[Ulrich Drepper]

Some gcc versions have problems with using local extern "C" struct-typed
variables in functions (see bug 15773 for more info).  The following patch
helps to fix the problem.

Index: gfx/src/nsDeviceContext.cpp
===================================================================
RCS file: /cvsroot/mozilla/gfx/src/nsDeviceContext.cpp,v
retrieving revision 3.40
diff -u -u -r3.40 nsDeviceContext.cpp
--- nsDeviceContext.cpp 1999/10/05 14:49:11     3.40
+++ nsDeviceContext.cpp 1999/10/07 20:42:59
@@ -201,10 +201,10 @@
   nsIRenderingContext *pContext;
   nsresult             rv;

-  static NS_DEFINE_CID(kRCCID, NS_RENDERING_CONTEXT_CID);
+  static NS_DEFINE_CID(kRCCID2, NS_RENDERING_CONTEXT_CID);

   aContext = nsnull;
-  rv = nsComponentManager::CreateInstance(kRCCID, nsnull, NS_GET_IID(nsIRenderi
ngContext), (void **)&pContext);
+  rv = nsComponentManager::CreateInstance(kRCCID2, nsnull, NS_GET_IID(nsIRender
ingContext), (void **)&pContext);

   if (NS_OK == rv) {
     rv = InitRenderingContext(pContext, aWidget);

Comment 1

[Peter Trudelle]

reassigning to pavlov for consideration triage

Comment 2

[Stuart Parmenter]

moving up on my radar so when i look at it tomorrow i see it

Comment 3

[Stuart Parmenter]

checked in fix

Comment 4

[Claudius Gayle]

code-level fic, marking VERIFIED.