1577662 - Ensure profile reset doesn't connect sync after decoupling lands

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect, P1)

Description

[Mark Hammond [:markh] [:mhammond]]

A few years ago, in bug 1377200, we discovered that a profile reset/refresh would disconnect sync due to the preferences being reset. As we decouple sync and fxa we are likely to hit the same issue again. We need to work out what we can do to avoid this.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:markh, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

It turns out the bug will be the opposite - users signed in but not connected to sync will find themselves syncing after a reset.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Gijs has some context around the decoupling work and also drew the short straw last time I touched this back in bug 1395332 - so apologies for drawing that straw again.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1577662 (part 1) - Allow profile refresh test to test multiple refresh scenarios.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: Bug 1577662 (part 2) - Profile reset now correctly handles that signed in to FxA doesn't always mean sync.

Depends on D47571

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d81fc0b39f4c
(part 1) - Allow profile refresh test to test multiple refresh scenarios. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/90a414a9c39c
(part 2) - Profile reset now correctly handles that signed in to FxA doesn't always mean sync. r=Gijs

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/d81fc0b39f4c
https://hg.mozilla.org/mozilla-central/rev/90a414a9c39c