Closed Bug 1577725 Opened 5 months ago Closed 5 months ago

Stop mutating CONTAINER_PREF_INSTALL_DEFAULTS in ext-contextualIdentities.js

Categories

(WebExtensions :: General, task)

task
Not set

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: robwu, Assigned: robwu)

Details

Attachments

(1 file)

https://searchfox.org/mozilla-central/rev/7088fc958db5935eba24b413b1f16d6ab7bd13ea/toolkit/components/extensions/parent/ext-contextualIdentities.js#122

      return Object.assign(CONTAINER_PREF_INSTALL_DEFAULTS, {
        "privacy.userContext.extension": value,
      });

The Object.assign call modifies and returns the first parameter. If callers modify the return value, then the changes will persist to the next call. This is likely undesired.

Assignee: nobody → rob
Status: NEW → ASSIGNED
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/2473f0d5d663
Stop modifying defaults in ext-contextualIdentities.js r=mixedpuppy
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Flags: needinfo?(rob)
Flags: needinfo?(rob) → qe-verify-
You need to log in before you can comment on or make changes to this bug.