1577725 - Stop mutating CONTAINER_PREF_INSTALL_DEFAULTS in ext-contextualIdentities.js

Status: RESOLVED FIXED

(WebExtensions :: General, task)

Description

[Rob Wu [:robwu]]

https://searchfox.org/mozilla-central/rev/7088fc958db5935eba24b413b1f16d6ab7bd13ea/toolkit/components/extensions/parent/ext-contextualIdentities.js#122

      return Object.assign(CONTAINER_PREF_INSTALL_DEFAULTS, {
        "privacy.userContext.extension": value,
      });

The Object.assign call modifies and returns the first parameter. If callers modify the return value, then the changes will persist to the next call. This is likely undesired.

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1577725 - Stop modifying defaults in ext-contextualIdentities.js

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2473f0d5d663
Stop modifying defaults in ext-contextualIdentities.js r=mixedpuppy

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/2473f0d5d663

Comment 4

[Alex Cornestean]

Hello,

Will this fix require manual validation? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag. Otherwise, could the "qe-verify-" flag be added? Thanks!

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2473f0d5d663