1577726 - Split tools/rewriting/ThirdPartyPaths.txt to have generated directories into another file

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

tools/rewriting/ThirdPartyPaths.txt used to contain only thirdparty code but it is now used to ignore some temporary directories.

We should separate them to clearly identify the later.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1577726 - Ride along: Remove a directory which doesn't exist anymore r?andi

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1577726 - Ride along: explicit the file names (lz4.c instead of lz4.*) r?andi

Depends on D44145

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1577726 - Move generated directories into a dedicated file (Generated.txt) from ThirdPartyPaths.txt r?ahal

Depends on D44146

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3249ffd467a2
Ride along: Remove a directory which doesn't exist anymore r=andi
https://hg.mozilla.org/integration/autoland/rev/d5b2fb678a67
Ride along: explicit the file names (lz4.c instead of lz4.*) r=andi

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1577726 - Ride along: Remove third_party from the clang tidy configuration as it isn't used r?andi

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3249ffd467a2
https://hg.mozilla.org/mozilla-central/rev/d5b2fb678a67

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3249ffd467a2
https://hg.mozilla.org/releases/mozilla-beta/rev/d5b2fb678a67

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95fc1c757f6a
Ride along: Remove third_party from the clang tidy configuration as it isn't used r=andi

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df7da1b22c2f
Move generated directories into a dedicated file (Generated.txt) from ThirdPartyPaths.txt r=ahal

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/95fc1c757f6a
https://hg.mozilla.org/mozilla-central/rev/df7da1b22c2f

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1577726 - Move a path from tools/rewriting/ThirdPartyPaths.txt to tools/rewriting/Generated.txt r?andi

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1577726 - Reorder tools/rewriting/ThirdPartyPaths.txt r?andi

Depends on D45158

Comment 13

[Sylvestre Ledru [:Sylvestre]]

here is the script that I wrote for that:

echo "" > tools/rewriting/generated.txt
for f in $(cat tools/rewriting/ThirdPartyPaths.txt); do
    if test ! -e $f; then
        echo $f >> tools/rewriting/Generated.txt
        sed -i -e "\|$f$|d" tools/rewriting/ThirdPartyPaths.txt
    fi;
done

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c1c88bcac8b
Move a path from tools/rewriting/ThirdPartyPaths.txt to tools/rewriting/Generated.txt r=andi

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29a4f1f27dde
Reorder tools/rewriting/ThirdPartyPaths.txt r=andi

Comment 16

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4c1c88bcac8b
https://hg.mozilla.org/mozilla-central/rev/29a4f1f27dde

Comment 17

[Sylvestre Ledru [:Sylvestre]]

Completed