Closed Bug 1577726 Opened 1 year ago Closed 1 year ago

Split tools/rewriting/ThirdPartyPaths.txt to have generated directories into another file

Categories

(Firefox Build System :: Source Code Analysis, task)

task
Not set

Tracking

(firefox70 fixed)

RESOLVED FIXED
Tracking Status
firefox70 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

Details

Attachments

(6 files)

tools/rewriting/ThirdPartyPaths.txt used to contain only thirdparty code but it is now used to ignore some temporary directories.

We should separate them to clearly identify the later.

Assignee: nobody → sledru
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3249ffd467a2
Ride along: Remove a directory which doesn't exist anymore r=andi
https://hg.mozilla.org/integration/autoland/rev/d5b2fb678a67
Ride along: explicit the file names (lz4.c instead of lz4.*) r=andi
Keywords: leave-open
Attachment #9089357 - Attachment description: Bug 1577726 - Move generated directories into a dedicated file (Generated.txt) from ThirdPartyPaths.txt → Bug 1577726 - Move generated directories into a dedicated file (Generated.txt) from ThirdPartyPaths.txt r?ahal
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95fc1c757f6a
Ride along: Remove third_party from the clang tidy configuration as it isn't used r=andi
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/df7da1b22c2f
Move generated directories into a dedicated file (Generated.txt) from ThirdPartyPaths.txt r=ahal

here is the script that I wrote for that:

echo "" > tools/rewriting/generated.txt
for f in $(cat tools/rewriting/ThirdPartyPaths.txt); do
    if test ! -e $f; then
        echo $f >> tools/rewriting/Generated.txt
        sed -i -e "\|$f$|d" tools/rewriting/ThirdPartyPaths.txt
    fi;
done
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c1c88bcac8b
Move a path from tools/rewriting/ThirdPartyPaths.txt to tools/rewriting/Generated.txt r=andi
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29a4f1f27dde
Reorder tools/rewriting/ThirdPartyPaths.txt r=andi

Completed

Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Regressions: 1596456
You need to log in before you can comment on or make changes to this bug.