Closed Bug 1577731 Opened 3 months ago Closed 3 months ago

Place the granted permissions icon on the right for RTL and add dark mode support for it

Categories

(Firefox :: Site Identity, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 70
Tracking Status
firefox70 --- verified

People

(Reporter: itiel_yn8, Assigned: johannh)

References

Details

(Keywords: rtl)

Attachments

(2 files)

Attached image Screenshot

See attached.

Adding this:

  -moz-context-properties: fill;
  fill: currentColor;

to the #identity-popup-permissions-header rule should add the dark mode support, and adding this rule:

#identity-popup-permissions-header:-moz-locale-dir(rtl) {
  background-position-x: right;
}

should fix the RTL placement of the icon.

Gah, not sure why I didn't catch that. Thanks for filing the bug, would you like to make a patch?

Flags: needinfo?(itiel_yn8)

(In reply to Johann Hofmann [:johannh] from comment #1)

Gah, not sure why I didn't catch that. Thanks for filing the bug, would you like to make a patch?

I don't mind, but not sure I'll have time today. Feel free to steal this if you'd like.

Flags: needinfo?(itiel_yn8)
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a0e19c276b3
Place the granted permissions icon on the right for RTL and add dark mode support for it. r=nhnt11
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.