1577731 - Place the granted permissions icon on the right for RTL and add dark mode support for it

Status: VERIFIED FIXED

(Firefox :: Site Identity, enhancement, P1)

Description

[Itiel]

Attachment: Screenshot

See attached.

Adding this:

  -moz-context-properties: fill;
  fill: currentColor;

to the #identity-popup-permissions-header rule should add the dark mode support, and adding this rule:

#identity-popup-permissions-header:-moz-locale-dir(rtl) {
  background-position-x: right;
}

should fix the RTL placement of the icon.

Comment 1

[Johann Hofmann [:johannh]]

Gah, not sure why I didn't catch that. Thanks for filing the bug, would you like to make a patch?

Comment 2

[Itiel]

(In reply to Johann Hofmann [:johannh] from comment #1)

Gah, not sure why I didn't catch that. Thanks for filing the bug, would you like to make a patch?

I don't mind, but not sure I'll have time today. Feel free to steal this if you'd like.

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1577731 - Place the granted permissions icon on the right for RTL and add dark mode support for it. r=nhnt11

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a0e19c276b3
Place the granted permissions icon on the right for RTL and add dark mode support for it. r=nhnt11

Comment 5

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/4a0e19c276b3

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4a0e19c276b3