1577733 - Switch to referencing engines by id instead of display names in SearchService

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Dale Harvey (:daleharvey)]

As mentioned in https://phabricator.services.mozilla.com/D42879

In SearchService we refer to engines by their displayname (eg: Google) instead of the engine id which is quite confusing and brittle at least for builtin engines, see if we can switch to using a stable id instead

Comment 1

[Mark Banner (:standard8)]

Parts of code that use the display name currently:

• _searchDefault (and associated searchDefault in cache) - the default engine from the engine list
• _currentEngine (current) - the user's default engine
• _searchOrder - the order of the engines from the engine list. This doesn't get saved in the cache.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1577733 - Change SearchService's _searchDefault/_searchPrivateDefault to reference engines by an ascii identifier instead of display names for the modern config. r?mikedeboer

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1577733 - Change SearchService's _searchOrder to reference engines by ascii identifier instead of display names for the modern config. r?mikedeboer" -a

Depends on D50295

Comment 4

[Mark Banner (:standard8)]

I ended up with a couple of follow-up bugs to be done at some stage later - bug 1590803 and bug 1590860. Although I was looking at ways of doing bug 1590860 in these patches (because the sort orders for getDefaultEngines are broken), I ended up deciding that was getting too complex and it only really affected restoring default for distributions.

Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=08bf8389631ca2db62b81491bec51d95e8db2558

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba7a039edd59
Change SearchService's _searchDefault/_searchPrivateDefault to reference engines by an ascii identifier instead of display names for the modern config. r=mikedeboer
https://hg.mozilla.org/integration/autoland/rev/270ccc6de9ad
Change SearchService's _searchOrder to reference engines by ascii identifier instead of display names for the modern config. r=mikedeboer" -a

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ba7a039edd59
https://hg.mozilla.org/mozilla-central/rev/270ccc6de9ad