Closed
Bug 1577744
Opened 5 years ago
Closed 5 years ago
WeakMapBase::getDelegate returns the original key if there is no delegate
Categories
(Core :: JavaScript: GC, task, P3)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(1 file)
I think getDelegate should return nullptr if there is no delegate, but it returns the original key at the moment. This means we may be doing more work than necessary. Most callers check for a null return value.
|
Assignee | |
Comment 1•5 years ago
|
||
|
||
Comment 2•5 years ago
|
||
Oh right, I think I did this better in the still-unlanded stack for incremental weak marking. Thanks.
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/445b8539779a Make getDelegate() return null for WeakMap keys that are not cross compartment wrappers r=sfink
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•