Closed Bug 1577746 Opened 2 months ago Closed 2 months ago

Enable various ESLint rules on dom/ that can be fixed automatically

Categories

(Core :: DOM: Core & HTML, task)

task
Not set
Points:
2

Tracking

()

RESOLVED FIXED
mozilla71
Iteration:
71.1 - Sept 2 - 15
Tracking Status
firefox71 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(3 files)

When we started enabling ESLint on dom/, we disabled a lot of rules to reduce the immediate churn and review patch size. I'd like to start enabling those now.

Starting with a few rules that are automatically fixed by ESLint:

  • object-shorthand
  • dot-notation
  • mozilla/no-useless-parameters
  • mozilla/no-useless-run-test
  • no-extra-boolean-cast
  • no-unneeded-ternary

This enables:

  • mozilla/no-useless-parameters
  • mozilla/no-useless-run-test
  • no-extra-boolean-cast
  • no-unneeded-ternary

Depends on D44150

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b3c5e0e1bc4
Enable ESLint rule object-shorthand for dom/. r=baku
https://hg.mozilla.org/integration/autoland/rev/0c1543381629
Enable ESLint rule dot-notation for dom/. r=baku
https://hg.mozilla.org/integration/autoland/rev/8459bff03c95
Automatically enable more ESLint rules for dom/. r=baku
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.