1577759 - Add keyboard check for mouse only interactive elements.

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, enhancement)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

A use case is where there is a click handler on a non focusable non semantic element. It can be clicked on but it isn't usable with keyboard or pretty much inaccessible to screen readers.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1577759 - add a keyboard check for non-focusable non-semantic elements that are interactive with mouse only. r=nchevobbe

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1577759 - add highlighter support for a keyboard check for non-focusable non-semantic elements. r=rcaliman

Depends on D44231

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1577759 - add strings and urls for a keyboard check type for non-focusable and non-semantic clickable elements. r=gl

Depends on D44232

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db44fcfe3ee3
add a keyboard check for non-focusable non-semantic elements that are interactive with mouse only. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/bb93809181cf
add highlighter support for a keyboard check for non-focusable non-semantic elements. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/de24dca77618
add strings and urls for a keyboard check type for non-focusable and non-semantic clickable elements. r=gl,fluent-reviewers,flod

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/db44fcfe3ee3
https://hg.mozilla.org/mozilla-central/rev/bb93809181cf
https://hg.mozilla.org/mozilla-central/rev/de24dca77618

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 9089484 [details]
Bug 1577759 - add strings and urls for a keyboard check type for non-focusable and non-semantic clickable elements. r=gl

Beta/Release Uplift Approval Request

• User impact if declined: If not included, users won't be able to see one of the more common problems with keyboard accessibility when performing the audit.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Just an additional type of a keyboard audit. Mostly adding a couple of strings and constants along with tests.
• String changes made/needed: accessibility.keyboard.issue.mouse.only in devtools/shared/locales/en-US/accessibility.properties and accessibility-keyboard-issue-mouse-only in devtools/client/locales/en-US/accessibility.ftl

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9089484 [details]
Bug 1577759 - add strings and urls for a keyboard check type for non-focusable and non-semantic clickable elements. r=gl

Accessibility fix, includes new tests. OK for uplift to beta 4.

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

This needs l10n permission.

remote:
remote: ************************** ERROR ****************************
remote:
remote: * File used for localization (devtools/shared/locales/en-US/accessibility.properties) altered in this changeset *
remote:
remote: This repository is string frozen. Please request explicit permission from
remote: release managers to break string freeze in your bug.
remote: If you have that explicit permission, denote that by including in
remote: your commit message l10n=...
remote: *************************************************************
remote:

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Can you approve those string changes for beta?

Comment 10

[Francesco Lodolo [:flod]]

I won't push back at this point in the cycle, but I can't help pointing out that there are always uplift requests for this tool (unless my memory is wrong), and that doesn't seem OK.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7f3993d1151b
https://hg.mozilla.org/releases/mozilla-beta/rev/e21d82636176
https://hg.mozilla.org/releases/mozilla-beta/rev/5da3c0a0771e