Closed Bug 1577759 Opened 4 months ago Closed 3 months ago

Add keyboard check for mouse only interactive elements.

Categories

(DevTools :: Accessibility Tools, enhancement)

enhancement
Not set

Tracking

(firefox70 fixed, firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox70 --- fixed
firefox71 --- fixed

People

(Reporter: yzen, Assigned: yzen)

Details

Attachments

(3 files)

A use case is where there is a click handler on a non focusable non semantic element. It can be clicked on but it isn't usable with keyboard or pretty much inaccessible to screen readers.

Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/db44fcfe3ee3
add a keyboard check for non-focusable non-semantic elements that are interactive with mouse only. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/bb93809181cf
add highlighter support for a keyboard check for non-focusable non-semantic elements. r=rcaliman
https://hg.mozilla.org/integration/autoland/rev/de24dca77618
add strings and urls for a keyboard check type for non-focusable and non-semantic clickable elements. r=gl,fluent-reviewers,flod
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9089484 [details]
Bug 1577759 - add strings and urls for a keyboard check type for non-focusable and non-semantic clickable elements. r=gl

Beta/Release Uplift Approval Request

  • User impact if declined: If not included, users won't be able to see one of the more common problems with keyboard accessibility when performing the audit.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Just an additional type of a keyboard audit. Mostly adding a couple of strings and constants along with tests.
  • String changes made/needed: accessibility.keyboard.issue.mouse.only in devtools/shared/locales/en-US/accessibility.properties and accessibility-keyboard-issue-mouse-only in devtools/client/locales/en-US/accessibility.ftl
Attachment #9089484 - Flags: approval-mozilla-beta?
Attachment #9089482 - Flags: approval-mozilla-beta?
Attachment #9089483 - Flags: approval-mozilla-beta?

Comment on attachment 9089484 [details]
Bug 1577759 - add strings and urls for a keyboard check type for non-focusable and non-semantic clickable elements. r=gl

Accessibility fix, includes new tests. OK for uplift to beta 4.

Attachment #9089484 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9089482 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9089483 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This needs l10n permission.

remote:
remote: ************************** ERROR ****************************
remote:
remote: * File used for localization (devtools/shared/locales/en-US/accessibility.properties) altered in this changeset *
remote:
remote: This repository is string frozen. Please request explicit permission from
remote: release managers to break string freeze in your bug.
remote: If you have that explicit permission, denote that by including in
remote: your commit message l10n=...
remote: *************************************************************
remote:

Can you approve those string changes for beta?

Flags: needinfo?(francesco.lodolo)

I won't push back at this point in the cycle, but I can't help pointing out that there are always uplift requests for this tool (unless my memory is wrong), and that doesn't seem OK.

Flags: needinfo?(francesco.lodolo)
You need to log in before you can comment on or make changes to this bug.