1577798 - Logged Content function is missing "jump to definition" icon in Omniscient Browser Toolbox

Status: RESOLVED FIXED

(DevTools :: Console, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Navigate to https://nchevobbe.github.io/demo/console-test-app.html
2. Open the console
3. Evaluate console.log(handleLog)

Expected results

The handleLog function appears in the Omniscient Browser Toolbox, with the "jump to definition" icon, allowing to navigate to the debugger

Actual results

The icon doesn't appear.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

This is because we don't have a location property in the grip.
And we don't have it because we don't get into this if block (devtools/server/actors/object/previewers.js#124-132 )

Basically, this:

const script = dbgGlobal.makeDebuggeeValue(obj.unsafeDereference()).script;

returns something falsy.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1577798 - Don't create a new Debugger instance in WebConsoleActor. r=ochameau.

Previously we were always getting the webconsole actor parent
thread actor to get the location of a script. That works well
in a tab, but when in the omniscient browser toolbox, we
need the appropriate global for this.
Since we only need the global debuggee to create a proper debuggee
value for the function, we remove the getGlobalDebugObject hook
and replace it with a makeDebuggeeValue function, where we can
re-use WebConsoleActor's makeDebuggeeValue.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5873711a3f08
Don't create a new Debugger instance in WebConsoleActor. r=ochameau,jlast.

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/5873711a3f08