Closed Bug 1577849 Opened 5 years ago Closed 5 years ago

Firefox Lockwise - filtered list shows entry from outside the filtered set after an entry is deleted

Categories

(Firefox :: about:logins, defect, P2)

Product:
Firefox
Component:
about:logins
Version:
70 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 71
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- disabled
firefox70 --- verified
firefox71 --- verified

People

(Reporter: egao, Assigned: jaws)

Details

(Whiteboard: [passwords:management] [skyline])

Attachments

(1 file)

Bug 1577849 - Move to the next visible login when the selected login is removed, respecting the applied search filter. r?MattN
47 bytes, text/x-phabricator-request
Details | Review

Firefox: 70.0a1 (2019-08-28) (64 ビット)
OS: macOS Mojave 10.14.6 (18G87)

Steps to reproduce:

  • open Firefox Lockwise
  • using the search bar located at top, filter for a criteria (eg. email address)
  • from the resulting filtered set, select the first entry
  • from the pane on the right, select and confirm deletion

Expected outcome:

  • Firefox Lockwise displays the next entry from the list

Actual outcome:

  • Firefox Lockwise selects and displays an entry unrelated to the filtered list
Whiteboard: [passwords:management] [skyline]
Priority: -- → P2
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31b7f250c929
Move to the next visible login when the selected login is removed, respecting the applied search filter. r=MattN

https://hg.mozilla.org/mozilla-central/rev/31b7f250c929

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

I have verified this issue on the latest Nightly 71.0a1 (2019-09-06) (64-bit) on Windows 10, MacOS 10.14 and Arch 4.14.
- The next login from the filtered list is displayed after delete a login.

Status: RESOLVED → VERIFIED
status-firefox69: --- → disabled
status-firefox70: --- → affected
status-firefox71: fixed → verified
status-firefox-esr60: --- → unaffected
status-firefox-esr68: --- → unaffected

Does this need uplift to beta70?

Flags: needinfo?(jaws)

Yes, it needs uplift. I am working with David Durst and MattN to coordinate a single uplift of multiple patches to make sure they land in order and are merged properly.

Flags: needinfo?(jaws)
Flags: qe-verify+

I have verified this issue on the Firefox Beta 70.0b8 (Build ID: 20190919164641) build on Windows 10 x64, Mac 10.14 and Ubuntu 18.04 x64.

  • The next login from the filtered list is displayed after delete a login.
status-firefox70: fixed → verified
Flags: qe-verify+
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla71 → Firefox 71
Version: unspecified → 70 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: