1577868 - Land new "Sign up" button strings for Fennec Onboarding & Activity Stream

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, task, P1)

Description

[Chris Peterson [:cpeterson]]

Vlad, here are the new Fennec Onboarding and New Tab strings. The following doc will always have the latest official strings and screenshots:

https://docs.google.com/document/d/1RF-h7po7YFqpHYeYwt-oYFvSU8Hypn9pAVHF7x_njcM/edit

The string revisions:

• Changed Onboarding and New Tab's Sign in buttons to say Sign up.
• Changed New Tab's Welcome to Firefox text to mention Firefox Sync and Already have an account? Sign in. The words Sign in are a link to same Account screen as all the Sign up buttons. This new text is supposed to avoid possible user confusion because users who already have accounts might not know they can sign in from the Sign up buttons. :)

Comment 1

[Vlad Baicu]

Attachment: Bug 1577868 - Updated Sign up buttons. r=flod

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8a3b033dcc8
Updated Sign up buttons. r=delphine

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a8a3b033dcc8

Comment 4

[Eliza Balazs]

Verified as fixed on 71.0a1 (2019-09-10) with

• Samsung Galaxy Tab S3 (Android 8; Tablet);
• Huawei Honor 8 (Android 7.0);
• OnePlus 5T (Android 9);
• Google Pixel XL (Android Q)
  I will mark this as verified on Firefox 71.

Comment 5

[Cosmin Sabou [:CosminS]]

Chris, Bug 1576170 conflicts with this one when trying to uplift to esr68. Does this bug also need uplifting? Bug 1576170 also adds strings.
Conflict looks like this https://irccloud.mozilla.com/pastebin/TlFoDQWt/

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Cosmin Sabou [:CosminS] from comment #5)

Chris, Bug 1576170 conflicts with this one when trying to uplift to esr68. Does this bug also need uplifting? Bug 1576170 also adds strings.
Conflict looks like this https://irccloud.mozilla.com/pastebin/TlFoDQWt/

Passing the needinfo to Vlad, the Fennec engineer who wrote these patches.

Vlad, what is the order in which your Onboarding patches (for strings and code) should be uplifted? Cosmin sees the following merge conflict when trying to uplift:

        <!-- Ignore drawables used for localized Top Sites. -->
        <ignore regexp="^.*?/res/drawable-[xhmdpi]+/suggestedsites_[a-z]+.png$" />
<<<<<<< local
        <ignore regexp="firstrun_signin_button2|activity_stream_signin_title|activity_stream_signin_description|activity_stream_signin_button" />
=======
        <ignore regexp="activity_stream_signin_title|activity_stream_signin_description|activity_stream_signup_button|
        activity_stream_signin_prompt|activity_stream_signin_prompt_button|firstrun_sendtab_title|firstrun_sendtab_message" />
>>>>>>> graft
    </issue>
    <issue id="Usability" severity="error" />

Comment 7

[Vlad Baicu]

Hello, the uplift order is going to be D43245, D43468, D44388, D44817, D45528, onboarding content diff, awesomescreen diff.

Currently we can only uplift (without introducing an incomplete feature) up to D43468 - these are diffs that introduce only some strings. D44388 brings changes to the sign up buttons but without the content, those are going to be introduced by the "onboarding content diff". We've received the resources from Sean and the diff is in progress.

Comment 8

[Vlad Baicu]

Comment on attachment 9089883 [details]
Bug 1577868 - Updated Sign up buttons. r=flod

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Part of the new sign up buttons feature
• User impact if declined: The sign up feature cannot be shipped without this patch
• Fix Landed on Version:
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This new feature will be validated with a PI request and has already undergone some testing.
• String or UUID changes made by this patch: firstrun_signup_button, activity_stream_signup_button, activity_stream_signin_prompt, activity_stream_signin_prompt_button

Comment 9

[Vlad Baicu]

Please see https://bugzilla.mozilla.org/show_bug.cgi?id=1576170#c23 for the landing order of the sign up button feature patches.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9089883 [details]
Bug 1577868 - Updated Sign up buttons. r=flod

New Fennec awesomescreen work targeting 68.2. Approved for Fennec 68.2b6.

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/0ac7cef84a63

Comment 12

[Eliza Balazs]

Verified as fixed on ESR 68.2b7 with Samsung Galaxy Tab S3 (Android 8; tablet), OnePlus 5T (Android 9), Prestigio Grace X5 (Android 4.4.2).
I will mark this as Verified.