1577916 - Stop using `using namespace std` at global scope in gfx/layers

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement)

Comment 1

[Eric Rahm [:erahm]]

Attachment: Bug 1577916 - Remove using namespace std from gfx/layers r=mattwoodrow!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e0fb526633d
Remove using namespace std from gfx/layers r=mattwoodrow

Comment 3

[Alexandru Michis [:malexandru]]

Backed out changeset 6e0fb526633d for build bustage at gfx/layers/composite/TextRenderer.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/d7b421037dc23d78a7e987c72fb53eb184a2ab36

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=6e0fb526633d060a8be5b842a4294c5432872f51&tochange=d7b421037dc23d78a7e987c72fb53eb184a2ab36&selectedJob=264603773

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264603773&repo=autoland&lineNumber=21982

[task 2019-09-02T17:04:28.006Z] 17:04:28 ERROR - /builds/worker/workspace/build/src/gfx/layers/composite/TextRenderer.cpp:115:54: error: unknown type name 'string'; did you mean 'String'?
[task 2019-09-02T17:04:28.006Z] 17:04:28 INFO - const string& aText,
[task 2019-09-02T17:04:28.006Z] 17:04:28 INFO - ^~~~~~
[task 2019-09-02T17:04:28.006Z] 17:04:28 INFO - String
[task 2019-09-02T17:04:28.006Z] 17:04:28 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefsBase.h:18:21: note: 'String' declared here
[task 2019-09-02T17:04:28.006Z] 17:04:28 INFO - typedef const char* String;
[task 2019-09-02T17:04:28.006Z] 17:04:28 INFO - ^
[task 2019-09-02T17:04:28.007Z] 17:04:28 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/gfx/layers/Unified_cpp_gfx_layers7.cpp:83:
[task 2019-09-02T17:04:28.007Z] 17:04:28 ERROR - /builds/worker/workspace/build/src/gfx/layers/composite/TextRenderer.cpp:114:37: error: out-of-line definition of 'RenderText' does not match any declaration in 'mozilla::layers::TextRenderer'
[task 2019-09-02T17:04:28.007Z] 17:04:28 INFO - RefPtr<TextureSource> TextRenderer::RenderText(TextureSourceProvider* aProvider,
[task 2019-09-02T17:04:28.007Z] 17:04:28 INFO - ^~~~~~~~~~
[task 2019-09-02T17:04:28.007Z] 17:04:28 ERROR - /builds/worker/workspace/build/src/gfx/layers/composite/TextRenderer.cpp:142:49: error: unknown type name 'string'; did you mean 'String'?
[task 2019-09-02T17:04:28.007Z] 17:04:28 INFO - const string& aText,
[task 2019-09-02T17:04:28.007Z] 17:04:28 INFO - ^~~~~~
[task 2019-09-02T17:04:28.007Z] 17:04:28 INFO - String
[task 2019-09-02T17:04:28.007Z] 17:04:28 INFO - /builds/worker/workspace/build/src/obj-firefox/dist/include/mozilla/StaticPrefsBase.h:18:21: note: 'String' declared here
[task 2019-09-02T17:04:28.007Z] 17:04:28 INFO - typedef const char* String;
[task 2019-09-02T17:04:28.008Z] 17:04:28 INFO - ^
[task 2019-09-02T17:04:28.008Z] 17:04:28 INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/gfx/layers/Unified_cpp_gfx_layers7.cpp:83:
[task 2019-09-02T17:04:28.008Z] 17:04:28 ERROR - /builds/worker/workspace/build/src/gfx/layers/composite/TextRenderer.cpp:141:20: error: out-of-line definition of 'RenderTextToDrawTarget' does not match any declaration in 'mozilla::layers::TextRenderer'
[task 2019-09-02T17:04:28.008Z] 17:04:28 INFO - void TextRenderer::RenderTextToDrawTarget(DrawTarget* aDrawTarget,
[task 2019-09-02T17:04:28.008Z] 17:04:28 INFO - ^~~~~~~~~~~~~~~~~~~~~~
[task 2019-09-02T17:04:28.008Z] 17:04:28 ERROR - /builds/worker/workspace/build/src/gfx/layers/composite/TextRenderer.cpp:163:33: error: member reference base type 'const mozilla::String' (aka 'const char *const') is not a structure or union
[task 2019-09-02T17:04:28.008Z] 17:04:28 INFO - for (uint32_t i = 0; i < aText.length(); i++) {
[task 2019-09-02T17:04:28.008Z] 17:04:28 INFO - ^
[task 2019-09-02T17:04:28.008Z] 17:04:28 INFO - 5 errors generated.
[task 2019-09-02T17:04:28.008Z] 17:04:28 INFO - /builds/worker/workspace/build/src/config/rules.mk:787: recipe for target 'Unified_cpp_gfx_layers7.o' failed
[task 2019-09-02T17:04:28.008Z] 17:04:28 ERROR - make[4]: *** [Unified_cpp_gfx_layers7.o] Error 1
[task 2019-09-02T17:04:28.008Z] 17:04:28 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/gfx/layers'
[task 2019-09-02T17:04:28.009Z] 17:04:28 INFO - make[4]: *** Waiting for unfinished jobs....

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b8416d02ed9
Remove using namespace std from gfx/layers r=mattwoodrow

Comment 5

[Eric Rahm [:erahm]]

Looks like a bad rebase, relanded.

Comment 6

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/1b8416d02ed9