1577959 - Permafailing Tier 2 TEST-UNEXPECTED-FAIL karma | activity-stream:CFRMessageProvider should have a total of 4 messages: expected [ Array(5) ] to have a length of 4 but got 5

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: rgurzau [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer.html#?job_id=264374586&repo=autoland
Full log: https://queue.taskcluster.net/v1/task/Z_mw3gwTTHCDlesitAwfPg/runs/0/artifacts/public/logs/live_backing.log

---

[task 2019-08-31T02:17:21.838Z] TEST START | karma
[task 2019-08-31T02:18:12.762Z] (node:76) DeprecationWarning: Tapable.plugin is deprecated. Use new API on .hooks instead
[task 2019-08-31T02:18:12.763Z] npm ERR! code ELIFECYCLE
[task 2019-08-31T02:18:12.763Z] npm ERR! errno 1
[task 2019-08-31T02:18:12.763Z] npm ERR! activity-streams@1.14.3 testmc:unit: karma start karma.mc.config.js
[task 2019-08-31T02:18:12.763Z] npm ERR! Exit status 1
[task 2019-08-31T02:18:12.763Z] npm ERR!
[task 2019-08-31T02:18:12.763Z] npm ERR! Failed at the activity-streams@1.14.3 testmc:unit script.
[task 2019-08-31T02:18:12.763Z] npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
[task 2019-08-31T02:18:12.763Z]
[task 2019-08-31T02:18:12.763Z] npm ERR! A complete log of this run can be found in:
[task 2019-08-31T02:18:12.763Z] npm ERR! /builds/worker/.npm/_logs/2019-08-31T02_18_12_756Z-debug.log
[task 2019-08-31T02:18:12.785Z] TEST-UNEXPECTED-FAIL karma | activity-stream:CFRMessageProvider should have a total of 4 messages: expected [ Array(5) ] to have a length of 4 but got 5
[task 2019-08-31T02:18:12.785Z] AssertionError@http://localhost:9876/base/node_modules/chai/chai.js?db92883971379fbea71a12c25b271c26a3afc3f6:9449:13
[task 2019-08-31T02:18:12.785Z] [3]</module.exports/Assertion.prototype.assert@http://localhost:9876/base/node_modules/chai/chai.js?db92883971379fbea71a12c25b271c26a3afc3f6:239:13
[task 2019-08-31T02:18:12.785Z] assertLength@http://localhost:9876/base/node_modules/chai/chai.js?db92883971379fbea71a12c25b271c26a3afc3f6:2487:10
[task 2019-08-31T02:18:12.785Z] chainableMethodWrapper@http://localhost:9876/base/node_modules/chai/chai.js?db92883971379fbea71a12c25b271c26a3afc3f6:7664:49
[task 2019-08-31T02:18:12.785Z] [6]</module.exports/assert.lengthOf@http://localhost:9876/base/node_modules/chai/chai.js?db92883971379fbea71a12c25b271c26a3afc3f6:5850:60
[task 2019-08-31T02:18:12.785Z] @http://localhost:9876/base/test/unit/unit-entry.js?da638f48041069de6585dd0612caa8b3e937d55c:106428:12
[task 2019-08-31T02:18:12.785Z]
[task 2019-08-31T02:18:12.785Z] TEST-UNEXPECTED-FAIL karma | activity-stream:CFRMessageProvider should always have xpinstallEnabled as targeting if it is an addon: expected 'usesFirefoxSync == false' to include '(xpinstallEnabled == true)'
[task 2019-08-31T02:18:12.785Z] AssertionError@http://localhost:9876/base/node_modules/chai/chai.js?db92883971379fbea71a12c25b271c26a3afc3f6:9449:13
[task 2019-08-31T02:18:12.785Z] [3]</module.exports/Assertion.prototype.assert@http://localhost:9876/base/node_modules/chai/chai.js?db92883971379fbea71a12c25b271c26a3afc3f6:239:13
[task 2019-08-31T02:18:12.785Z] include@http://localhost:9876/base/node_modules/chai/chai.js?db92883971379fbea71a12c25b271c26a3afc3f6:940:10
[task 2019-08-31T02:18:12.785Z] chainableMethodWrapper@http://localhost:9876/base/node_modules/chai/chai.js?db92883971379fbea71a12c25b271c26a3afc3f6:7664:49
[task 2019-08-31T02:18:12.785Z] [6]</module.exports/assert.include@http://localhost:9876/base/node_modules/chai/chai.js?db92883971379fbea71a12c25b271c26a3afc3f6:5106:51
[task 2019-08-31T02:18:12.785Z] @http://localhost:9876/base/test/unit/unit-entry.js?da638f48041069de6585dd0612caa8b3e937d55c:106448:16
[task 2019-08-31T02:18:12.785Z]

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Intermittent Failures Robot]

7 failures in 5047 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-central: 1
• mozilla-inbound: 1

Platform breakdown:

• linux64: 7

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1577959&startday=2019-08-26&endday=2019-09-01&tree=all

Comment 3

[Andrei Oprea [:andreio]]

Fixed in latest mozilla/central merge in Github.
https://github.com/mozilla/activity-stream/commit/e8776a3bee35a062f8e7591d906bce130095ddd7

Comment 4

[Intermittent Failures Robot]

4 failures in 4408 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1
• autoland: 1
• mozilla-central: 1
• mozilla-inbound: 1

Platform breakdown:

• linux64: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1577959&startday=2019-09-02&endday=2019-09-08&tree=all

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/eb7346d52181

Comment 6

[Intermittent Failures Robot]

9 failures in 4637 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 6
• mozilla-central: 1
• mozilla-inbound: 1
• mozilla-beta: 1

Platform breakdown:

• linux64: 9

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1577959&startday=2019-09-09&endday=2019-09-15&tree=all

Comment 7

[Intermittent Failures Robot]

1 failures in 4350 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1577959&startday=2019-09-16&endday=2019-09-22&tree=all

Comment 8

[Ed Lee :Mardak]

Attachment: Bug 1577959 - Update tier 2 tests for Bug 1571022 Conditional rendering for CFR feature recommendations

https://github.com/mozilla/activity-stream/commit/e8776a3bee35a062f8e7591d906bce130095ddd7

Comment 9

[Ed Lee :Mardak]

Comment on attachment 9094694 [details]
Bug 1577959 - Update tier 2 tests for Bug 1571022 Conditional rendering for CFR feature recommendations

Beta/Release Uplift Approval Request

• User impact if declined: None - test only fix
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Test has been fixed in m-c for 2 weeks. Still failing on beta, but the test only runs when browser/components/newtab changes, so it's low failure occurrence anyway.
• String changes made/needed:

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9094694 [details]
Bug 1577959 - Update tier 2 tests for Bug 1571022 Conditional rendering for CFR feature recommendations

Test fix, OK for uplift for beta 10.

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6f62baa8eaaa

Comment 12

[Intermittent Failures Robot]

1 failures in 4530 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform breakdown:

• linux64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1577959&startday=2019-09-23&endday=2019-09-29&tree=all