1577970 - "Search Messages" window's "Move" button is broken (TB 68)

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[mosielski]

Attachment: snap.jpg

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Thunderbird version 68, after the last update there was a problem in the search engine for letters, earlier after searching for a group of letters you could select these lists and manually holding the mouse to move to any directory, now I can't do the same the Move button at the bottom does not work, the problem is in the letter search engine.

Expected results:

withdrawal of function as in the previous version, manual transfer of mass mailing letters from search engines

Comment 1

[Jorg K (CEST = GMT+2)]

Confirmed. Thanks for reporting. We might have to split it into two bugs for the two issues here: Drag & Drop and the Move button.

BTW, using the move button gives this in the error console:
NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgDBView.doCommandWithFolder] folderDisplay.js:1819
doCommandWithFolder chrome://messenger/content/folderDisplay.js:1819
MoveMessageInSearch chrome://messenger/content/SearchDialog.js:541
oncommand chrome://messenger/content/SearchDialog.xul:1

Alice, can you find the regression(s) for us.

Aceman, can you see how we can fix this quickly.

Comment 2

[Alice0775 White]

Jorg K,
What is / How to open the "Search Messages" windows?

Comment 3

[Jorg K (CEST = GMT+2)]

Right click onto a folder, "Search Messages", or Ctrl+Shift+F.

Comment 4

[Jorg K (CEST = GMT+2)]

Aceman, since the dragging works from the main window's thread pane (tree), I hope there's just a missing script in the search window's XUL file.

Comment 5

[Alice0775 White]

Regression window(drag and drop issue):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=9c6c4038b3b5ab074c1d9c2bf91bae0a062adaab&tochange=89435f04afee556e91d8f17634cd377dff5ac8d2
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=b4aeb99d1cb601e5a5288ca05630913fa8528a1c&tochange=6862624e24d005fb4f8fb07c6800d2acef1d287e

Regression window("Move To" button issue):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=f00b3cb050f365d2edf65b0fb83f9035f45b52e6&tochange=d714bac9fcfa78997c1de9d92118b61d028dedd9
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=58f1d879059c62ddeaf4b4fcf2624fb2c66d6ab9&tochange=7ffabb358c4255897db3ceb09cad21a4731cb0ae

Comment 6

[Jorg K (CEST = GMT+2)]

OK, so the first issue was cause in bug 1446609 and should be easy to fix. The second one comes from bug 1558565. Paul, can you take a look if we don't get to it sooner.

Comment 7

[Jorg K (CEST = GMT+2)]

On trunk, the move issue move to:
JavaScript error: chrome://messenger/content/folderDisplay.js, line 1822: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgDBView.doCommandWithFolder]

https://searchfox.org/comm-central/rev/a78b910c726fa294c42e477a343817fd85e232bd/mail/base/content/folderDisplay.js#1822
calling
https://searchfox.org/comm-central/rev/a78b910c726fa294c42e477a343817fd85e232bd/mailnews/base/src/nsMsgDBView.cpp#2406

Hmm, the Move button does display a folder tree, so it's likely caused by
50955fe1cb9823bed5efef3d7b5e5f076e87f0a1 Paul Morris — Bug 1558565 - Refactor the folder-menupopup code; r=mkmelin

Comment 8

[:aceman]

I'd guess that not a script is missing but the folder picker is not passing the target folder properly.
Inside MoveMessageInSearch in SearchDialog.js, the file-uri attribute for constructing the target folder is empty.

Comment 9

[:aceman]

Actually also the 'id' attribute of the selected folder is empty, which I think we discussed whether to remove it as it may not be unique.
I'll see which other attribute we use to pass the folder URI.

Comment 10

[Jorg K (CEST = GMT+2)]

Hey Alice, many thanks, as always!!

Comment 11

[:aceman]

Attachment: 1577970.patch - move button

Fix the Move button. id an file-uri is not set anywhere so use the item._folder directly as we do in other places.

Interestingly, Seamonkey is not affected, they already get _folder.

I'm not going to fix the drag and drop problem right now, it is not trivial. In bug 1446609 they only removed utilityoverlay.xul from searchDialog.xul but it does not seem as it had something for drag and drop inside. You may want to split it into a new bug.

Comment 12

[Jorg K (CEST = GMT+2)]

I'm not going to fix the drag and drop problem right now, it is not trivial. In bug 1446609 they only removed utilityoverlay.xul from searchDialog.xul but it does not seem as it had something for drag and drop inside. You may want to split it into a new bug.

Hmm, OK, that removed utilityOverlay.js, but putting this back doesn't help.

Comment 13

[Jorg K (CEST = GMT+2)]

OK, filed bug 1577987 for the drag and drop issue.

Comment 14

[Jorg K (CEST = GMT+2)]

Comment on attachment 9089616 [details] [diff] [review]
1577970.patch - move button

Works for me, nice to see that rubbish go.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b345c245522a
pass the selected folder to MoveMessageInSearch() directly instead of the removed 'id' attribute. r=jorgk

Comment 16

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/d14ddf9120977b50e884da0c4f15448fe6290f0d

Comment 17

[Jorg K (CEST = GMT+2)]

Working in 68.1.