1577989 - TB 68: Cannot activate checkbox in caldav calendar to send via client

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[d.spitznagel]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:60.0) Gecko/20100101 Firefox/60.0

Steps to reproduce:

1. Added caldav based calendar from our kolab server (sabredav).
2. Under properties of this calendar checked "prefer to send over client" than confirmed change with OK.
   I don't know the exact option because I use "german" TB.

Actual results:

The aforesaid checkbox option wasn't saved.
Tried repeatedly to no avail.

Expected results:

Changing the aforesaid checkbox option should be saved when OK is pressed.
I also checked in configurator if "calendar.registry.xxxxxx.forceEmailScheduling is available > NO.
Adding the key manually makes client-side email scheduling work but than the option cannot be disabled under calendar properties.

Comment 1

[Jorg K (CEST = GMT+2)]

Can some Calendar person check this "blocker"?

Comment 2

[Stefan Sitter [:ssitter]]

https://wiki.mozilla.org/BMO/UserGuide/BugFields#bug_severity
Does not block development and/or testing work, does not affect a large number of users -> no blocker.

Regarding forceEmailScheduling I can see a tooltip that says: "This option is only available if the calendar server handles scheduling." https://searchfox.org/comm-central/source/calendar/locales/en-US/chrome/lightning/lightning.dtd#51

Looks like the code to setup the checkbox is here: https://searchfox.org/comm-central/source/calendar/providers/caldav/content/caldav-lightning-utils.js#56

It checks if the calendar supports auto-schedule capability. Maybe the used caldav server doesn't announce its capabilities correctly to Lightning?

Comment 3

[d.spitznagel]

This checkbox works flawlessly with TB 60.8.0 > ergo it is a bug.
Yes our Server (Kolab) supports email auto-scheduling and it is disabled because of different problems with different clients.
We currently use TB 60.8.0 successfully with this checkbox and it will soon be EOL. So at some point I will be forced to update to TB 68.0 and this is a "blocker" - that's why I set it - sorry If I missunderstood it's purpose.

Comment 4

[d.spitznagel]

Even when I enable email auto-scheduling in Kolab this checkbox does NOT work with TB 68.0, but works again flawlessly with TB 60.8.0.
I think this a clearly a "force" option, so it should not matter what the server supports or not.

Comment 5

[d.spitznagel]

In the meantime I have found two other bugs with TB 68.0 which TB 60.8.0 does not have.
These two bugs are also with Lightning - i will report them when I have more time.
Sorry guys, but Lighning in TB 68.0 is currently not in a good shape.

Comment 6

[Geoff Lankow (:darktrojan)]

Attachment: 1577989-properties-onaccept-1.diff

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 9089776 [details] [diff] [review]
1577989-properties-onaccept-1.diff

Please set the flags when you do there review.

Comment 8

[Jorg K (CEST = GMT+2)]

In the meantime I have found two other bugs with TB 68.0 which TB 60.8.0 does not have.
These two bugs are also with Lightning - i will report them when I have more time.

Reporter, can you please file those bugs and CC me on the new bugs so we can get them fixed quickly like this one here.

Comment 9

[Paul Morris [:pmorris]]

Comment on attachment 9089776 [details] [diff] [review]
1577989-properties-onaccept-1.diff

Review of attachment 9089776 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.  r+

Comment 10

[Jorg K (CEST = GMT+2)]

TB 70 beta:
https://hg.mozilla.org/releases/comm-beta/rev/aecec1ae44601f6a55111e35929770cdd8823df6

Pushed that to trigger a build in comm-beta.

Philipp, we need the 71 milestone.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c6917113d1a3
Call correct onAcceptDialog function in calendar properties dialog. r=pmorris

Comment 12

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR / Cal 7.0:
https://hg.mozilla.org/releases/comm-esr68/rev/3aaea8db1876eb74c02c6652946ce1b9b55d5ffa

Comment 13

[d.spitznagel]

I can confirm this this fixed with TB from here...
32bit: https://queue.taskcluster.net/v1/task/b1ItT68HT0uJA9jkhbd7Eg/runs/0/artifacts/public/build/install/sea/target.installer.exe

Thank you.