Closed Bug 1577996 Opened 5 years ago Closed 5 years ago

ThreadActor sends unexpected messages

Categories

(DevTools :: General, defect, P2)

69 Branch
defect

Tracking

(firefox-esr60 unaffected, firefox-esr68 unaffected, firefox67 unaffected, firefox68 unaffected, firefox69 wontfix, firefox70 wontfix, firefox71 fix-optional)

RESOLVED WORKSFORME
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox67 --- unaffected
firefox68 --- unaffected
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- fix-optional

People

(Reporter: hbenl, Unassigned)

References

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

When I use the Firefox remote debug protocol (I am the maintainer of the VS Code debugger for Firefox), I get unexpected messages that only contain the sender, a ThreadActor (e.g. {"from":"server1.conn0.child1/thread20"}).
It seems that these messages are triggered when I send attach, resume or interrupt requests. Each of these requests results in a corresponding response message (e.g. {"from":"server1.conn0.child1/thread20","type":"resumed"} for a resume request), but then I get an additional message as shown above.
The problem is that there are other requests for which the response looks exactly the same and in general I can't tell which request triggered the message. This means that I can't tell if a request that I sent to Firefox has been handled or not.

Actual results:

I get unexpected messages from Firefox in addition to the expected responses.

Expected results:

I should only get the expected responses.

I have noticed this in the developer edition, branches 69 and 70. It doesn't happen in Firefox 68.

Hi @hbenl, for now what I can do for this issue is just setting a component, if isn't the right one please fell free to change it.
Regards,
Liviu

Component: Untriaged → General
Product: Firefox → DevTools

Thanks for filing Holger. Let me needinfo Honza here who will be able to investigate or find the right person for you.

Flags: needinfo?(odvarko)

Jason, can you please look at this?
What should be the priority?

Honza

Flags: needinfo?(odvarko) → needinfo?(jlaster)

This seems like a recent regression based on comment 1.

What kind of messages are you seeing?

Flags: needinfo?(jlaster)

(In reply to Jason Laster [:jlast] from comment #6)

What kind of messages are you seeing?

(In reply to hbenl from comment #0)

When I use the Firefox remote debug protocol (I am the maintainer of the VS Code debugger for Firefox), I get unexpected messages that only contain the sender, a ThreadActor (e.g. {"from":"server1.conn0.child1/thread20"}).

@jlast Sorry, I had somehow missed your comment.
@past Thanks, that's what I should have answered.

I am setting the priority to P2 since this looks like a blocker for our VSCode Firefox Debugger extension.

Jason, can you please help Holger to solve this issue?

Thanks,
Honza

Flags: needinfo?(jlaster)
Priority: -- → P2
Blocks: dbg-71
Status: UNCONFIRMED → NEW
Ever confirmed: true

loganfsmyth

Attach and resume do send 2 separate packets each, but I thought they were distinct? When you attach, we pause the debugger too, so we send one packet that is the response to the attach request, and one packet that is the paused event notification. Similarly, resume sends a response packet for the resumed request and also emits a resumed event (edited)

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(jlaster)
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.