Closed Bug 1578051 Opened 3 months ago Closed 3 months ago

[protection panel] more information "i" button doesn't have focus indicator/outline until activated

Categories

(Firefox :: Site Identity, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox70 + verified
firefox71 --- verified

People

(Reporter: asa, Assigned: timhuang)

References

Details

(Keywords: access, Whiteboard: [privacy-panel][skyline][access-p2])

Attachments

(2 files)

In the protections panel accessed from the shield icon in the address bar, the more information "i" button doesn't get a focus indicator/outline when you tab to it. It only shows a focus outline after you've activated it and expanded the more information sub-panel. The button should have a focus indicator when you tab to it.

Whiteboard: [skyline] → [privacy-panel][skyline]
Assignee: nobody → tihuang
Status: NEW → ASSIGNED

By adding a ':-moz-focusring' on the info button.

Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bc2c5c373f49
Apply hovering effect on the info button if it gets tab focus. r=nhnt11
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Comment on attachment 9091680 [details]
Bug 1578051 - Apply hovering effect on the info button if it gets tab focus. r?nhnt11!

Beta/Release Uplift Approval Request

  • User impact if declined: The info button won't get focus indicator while tab to it.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Click the shield icon to open the protections panel
  1. Press Tab
  2. Check whether the info button gets focus and has a hovering effect on it.
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This is only the CSS change. Should be low risk.
  • String changes made/needed: None
Attachment #9091680 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Reproduced the issue on affected Beta 70.0b5 on Windows 10 x64.
Verified - fixed on latest Nightly 71.0a1 (2019-09-13) (64-bit) on Windows 10 x64, MacOS 10.13 and Ubuntu 18.04.

Waiting for uplift to beta.

Comment on attachment 9091680 [details]
Bug 1578051 - Apply hovering effect on the info button if it gets tab focus. r?nhnt11!

Polish for skyline, fine for uplift for beta 7.

Attachment #9091680 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified - fixed on latest Beta 70.0b7 Windows 10 x64, MacOS 10.13 and Ubuntu 18.04.
On macOS there is a slight difference that was reported as Bug 1581749.
Closing this as verified - fixed.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
See Also: → 1581749
Whiteboard: [privacy-panel][skyline] → [privacy-panel][skyline][access-p2]
You need to log in before you can comment on or make changes to this bug.