1578051 - [protection panel] more information "i" button doesn't have focus indicator/outline until activated

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect)

Description

[Asa Dotzler [:asa]]

Attachment: Focus outline missing when more info is collapsed but showing when it's expanded

In the protections panel accessed from the shield icon in the address bar, the more information "i" button doesn't get a focus indicator/outline when you tab to it. It only shows a focus outline after you've activated it and expanded the more information sub-panel. The button should have a focus indicator when you tab to it.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1578051 - Apply hovering effect on the info button if it gets tab focus. r?nhnt11!

By adding a ':-moz-focusring' on the info button.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc2c5c373f49
Apply hovering effect on the info button if it gets tab focus. r=nhnt11

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bc2c5c373f49

Comment 4

[Tim Huang[:timhuang]]

Comment on attachment 9091680 [details]
Bug 1578051 - Apply hovering effect on the info button if it gets tab focus. r?nhnt11!

Beta/Release Uplift Approval Request

• User impact if declined: The info button won't get focus indicator while tab to it.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Click the shield icon to open the protections panel

2. Press Tab
3. Check whether the info button gets focus and has a hovering effect on it.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is only the CSS change. Should be low risk.
• String changes made/needed: None

Comment 5

[Timea Cernea [:tbabos][inactive]]

Reproduced the issue on affected Beta 70.0b5 on Windows 10 x64.
Verified - fixed on latest Nightly 71.0a1 (2019-09-13) (64-bit) on Windows 10 x64, MacOS 10.13 and Ubuntu 18.04.

Waiting for uplift to beta.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9091680 [details]
Bug 1578051 - Apply hovering effect on the info button if it gets tab focus. r?nhnt11!

Polish for skyline, fine for uplift for beta 7.

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d2cdf3047932

Comment 8

[Timea Cernea [:tbabos][inactive]]

Verified - fixed on latest Beta 70.0b7 Windows 10 x64, MacOS 10.13 and Ubuntu 18.04.
On macOS there is a slight difference that was reported as Bug 1581749.
Closing this as verified - fixed.