1578052 - [protection panel] focus indicator/outline on protections toggle nearly invisible because it overlaps the toggle

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Asa Dotzler [:asa]]

Attachment: The focus indictor is barely visible around the toggle

In the protections panel accessed from the shield icon in the address bar, the focus indicator/outline for the protections toggle is nearly invisible because it overlaps the toggle. The outline should be outside of the toggle so it's visible.

Comment 1

[Asa Dotzler [:asa]]

The same issue exists in the off state of the toggle. The focus outline isn't really an outline so it's difficult to see.

Comment 2

[Tim Huang[:timhuang]]

Attachment: Bug 1578052 - Add the focus outline of the TP switch in protections panel. r?nhnt11!

We add the focus outline of the TP switch according to different
platforms.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fd2cf480008
Add the focus outline of the TP switch in protections panel. r=nhnt11

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/9fd2cf480008

Comment 6

[Johann Hofmann [:johannh]]

Tim, can you request uplift on this? :)

Comment 7

[Tim Huang[:timhuang]]

Comment on attachment 9092969 [details]
Bug 1578052 - Add the focus outline of the TP switch in protections panel. r?nhnt11!

Beta/Release Uplift Approval Request

• User impact if declined: The TP switch in the protections panel won't get a correct focusing effect if a user tabs to it.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open any web page

2. Click the shield icon to open the protections panel.
3. Press "Tab" several times to focus on the TP switch.
4. Check whether the focus indicator is correctly applied.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This only changes the CSS. So, it is low risky.
• String changes made/needed: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9092969 [details]
Bug 1578052 - Add the focus outline of the TP switch in protections panel. r?nhnt11!

Polish fix for the Protections Panel. Approved for 70.0b8.

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/d15f21350cb7

Comment 10

[Ciprian Georgiu, Desktop QA]

This issue is verified as fixed on latest Nightly 71.0a1 and Beta 70.0b9 across platforms: Win 10 x64, macOS 10.13 and Ubuntu 18.04 x64.