Closed Bug 1578065 Opened 5 years ago Closed 5 years ago

Port |Bug 433238 - Password manager contextual menu password field manual fill| to SeaMonkey

Categories

(SeaMonkey :: General, enhancement)

Product:
SeaMonkey
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr wontfix, seamonkey2.63 wontfix, seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.68
Tracking Flags:
Tracking Status
seamonkey2.49esr --- wontfix
seamonkey2.63 --- wontfix
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: SM2.53.1)

Attachments

(4 files, 2 obsolete files)

Contextual menu for login/password fields v1.1
15.14 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
Enable loginmanagercontextmenu module (c-253 and c-257)
928 bytes, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review
Enable loginmanagercontextmenu module (c-c)
961 bytes, patch
Details | Diff | Splinter Review
1578065_enable_loginmanagercontextmenu_alternate.patch
697 bytes, patch
iannbugzilla
: approval-comm-esr60+
Details | Diff | Splinter Review

Port the following:

  • Bug 433238 - Password manager contextual menu password field manual fill

[Approval Request Comment]
Regression caused by (bug #): n/a
User impact if declined: Not as easy to access login information
Testing completed (on m-c, etc.): 2.53
Risk to taking this patch (and alternatives if risky): None
String changes made by this patch: 8 strings added to contentAreaCommands.dtd

Attachment #9089707 - Flags: review?(frgrahl)
Attachment #9089707 - Flags: approval-comm-release?
Attachment #9089707 - Flags: approval-comm-esr60?

Need to make allowances for mailnews context menus

Attachment #9089707 - Attachment is obsolete: true
Attachment #9089707 - Flags: review?(frgrahl)
Attachment #9089707 - Flags: approval-comm-release?
Attachment #9089707 - Flags: approval-comm-esr60?
Attachment #9089779 - Flags: review?(frgrahl)
Attachment #9089779 - Flags: approval-comm-release?
Attachment #9089779 - Flags: approval-comm-esr60?

Extra module needed for context menus on login/password fields

Attachment #9089865 - Flags: review?(frgrahl)
Attachment #9089865 - Flags: approval-comm-release?
Attachment #9089865 - Flags: approval-comm-esr60?
Depends on: 1578303

Strictly the approval flags should be for approval-mozilla-* but as they are to go into the SM branches using the equivalent approval-comm-*

Attachment #9089865 - Attachment is obsolete: true
Attachment #9089865 - Flags: review?(frgrahl)
Attachment #9089865 - Flags: approval-comm-release?
Attachment #9089865 - Flags: approval-comm-esr60?
Attachment #9089927 - Flags: review?(frgrahl)
Attachment #9089927 - Flags: approval-comm-release?
Attachment #9089927 - Flags: approval-comm-esr60?
Depends on: 1578062
Attachment #9089927 - Attachment description: Enable loginmanagercontextmenu module → Enable loginmanagercontextmenu module (c-c)
Attachment #9089927 - Attachment description: Enable loginmanagercontextmenu module (c-c) → Enable loginmanagercontextmenu module (c-253)
Attachment #9089927 - Attachment description: Enable loginmanagercontextmenu module (c-253) → Enable loginmanagercontextmenu module (c-253 and c-257)
Comment on attachment 9089779 [details] [diff] [review]
Contextual menu for login/password fields v1.1

lgtm

r/a = me
Attachment #9089779 - Flags: review?(frgrahl)
Attachment #9089779 - Flags: review+
Attachment #9089779 - Flags: approval-comm-release?
Attachment #9089779 - Flags: approval-comm-release+
Attachment #9089779 - Flags: approval-comm-esr60?
Attachment #9089779 - Flags: approval-comm-esr60+
Comment on attachment 9089927 [details] [diff] [review]
Enable loginmanagercontextmenu module (c-253 and c-257)

r/a=me for  SeaMonkey 2.53 and 2.57 release branch only.
Attachment #9089927 - Flags: review?(frgrahl)
Attachment #9089927 - Flags: review+
Attachment #9089927 - Flags: approval-comm-release?
Attachment #9089927 - Flags: approval-comm-release+
Attachment #9089927 - Flags: approval-comm-esr60?
Attachment #9089927 - Flags: approval-comm-esr60+

Should we use this one until our release branch is ready?

Attachment #9091314 - Flags: approval-comm-esr60+
Attachment #9091314 - Flags: approval-comm-esr60+ → approval-comm-esr60?
Comment on attachment 9091314 [details] [diff] [review]
1578065_enable_loginmanagercontextmenu_alternate.patch

yes, a=me
Attachment #9091314 - Flags: approval-comm-esr60? → approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/407b577a46ff
Port Bug 433238 "Password manager contextual menu password field manual fill" to SeaMonkey. r=frg

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED

https://hg.mozilla.org/releases/comm-esr60/rev/98612418d9e0fe0db4e79e97e598edd7316f7301
Port Bug 433238 "Password manager contextual menu password field manual fill" to SeaMonkey.

https://hg.mozilla.org/releases/comm-esr60/rev/901914f5aa1be2c111238e24e807715908abea91
Include LoginManagerContextMenu.jsm in SeaMonkey builds.

status-seamonkey2.49esr: --- → wontfix
status-seamonkey2.53: --- → affected
status-seamonkey2.57esr: --- → fixed
status-seamonkey2.63: --- → wontfix
Target Milestone: --- → seamonkey2.68
Whiteboard: SM2.53.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: