Closed Bug 1578117 Opened 2 years ago Closed 2 years ago

Revert the changes of bug 1577659 for the <statuspanel>

Categories

(Thunderbird :: Mail Window Front End, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 70.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

After bug 1577659 the statuspanel doesn't work as it should: With hidden status bar when hovering a link in a message, the link should be shown in a small popup on the bottom and hide again when no link is hovered. Now a full status bar is shown and goes no more away.

Revert it for <statuspanel>.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9089771 - Flags: review?(mkmelin+mozilla)
Attachment #9089771 - Flags: review?(mkmelin+mozilla) → review?(khushil324)
Comment on attachment 9089771 [details] [diff] [review]
1578117-stauspanel.patch

Review of attachment 9089771 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/content/mailWindow.js
@@ +293,4 @@
>                          encodeURIComponent);
>      }
>  
>      if (!document.getElementById("status-bar").hidden) {

It is still not working. We need to change this if condition.
Attachment #9089771 - Flags: review?(khushil324)
Attached patch 1578117-stauspanel.patch (obsolete) — Splinter Review
Attachment #9089771 - Attachment is obsolete: true
Attachment #9089796 - Flags: review?(richard.marti)
Comment on attachment 9089796 [details] [diff] [review]
1578117-stauspanel.patch

This doesn't work. The links are always shown in the statuspanel also when the status bar is shown. When the status bar is shown, the link should be shown inside the status bar.

Have you tried my patch?
Attachment #9089796 - Flags: review?(richard.marti) → review-

(In reply to Richard Marti (:Paenglab) from comment #4)

Have you tried my patch?

Yes, it worked that way.
I thought the link should be always shown in the statuspanel if statuspanel is available in the window.

Attachment #9089771 - Attachment is obsolete: false
Attachment #9089771 - Flags: review+
Attachment #9089796 - Attachment is obsolete: true

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2cc01a0d1d08
Revert the changes of bug 1577659 for the <statuspanel>. r=mkmelin DONTBUILD

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 70.0

Too bad, got landed with wrong reviewer.

You need to log in before you can comment on or make changes to this bug.