Closed
Bug 1578117
Opened 5 years ago
Closed 5 years ago
Revert the changes of bug 1577659 for the <statuspanel>
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 70.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
1.83 KB,
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
After bug 1577659 the statuspanel doesn't work as it should: With hidden status bar when hovering a link in a message, the link should be shown in a small popup on the bottom and hide again when no link is hovered. Now a full status bar is shown and goes no more away.
Assignee | ||
Comment 1•5 years ago
|
||
Revert it for <statuspanel>.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9089771 -
Flags: review?(mkmelin+mozilla)
Updated•5 years ago
|
Attachment #9089771 -
Flags: review?(mkmelin+mozilla) → review?(khushil324)
Comment 2•5 years ago
|
||
Comment on attachment 9089771 [details] [diff] [review] 1578117-stauspanel.patch Review of attachment 9089771 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/base/content/mailWindow.js @@ +293,4 @@ > encodeURIComponent); > } > > if (!document.getElementById("status-bar").hidden) { It is still not working. We need to change this if condition.
Attachment #9089771 -
Flags: review?(khushil324)
Comment 3•5 years ago
|
||
Attachment #9089771 -
Attachment is obsolete: true
Attachment #9089796 -
Flags: review?(richard.marti)
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9089796 [details] [diff] [review] 1578117-stauspanel.patch This doesn't work. The links are always shown in the statuspanel also when the status bar is shown. When the status bar is shown, the link should be shown inside the status bar. Have you tried my patch?
Attachment #9089796 -
Flags: review?(richard.marti) → review-
Comment 5•5 years ago
|
||
(In reply to Richard Marti (:Paenglab) from comment #4)
Have you tried my patch?
Yes, it worked that way.
I thought the link should be always shown in the statuspanel if statuspanel is available in the window.
Updated•5 years ago
|
Attachment #9089771 -
Attachment is obsolete: false
Attachment #9089771 -
Flags: review+
Updated•5 years ago
|
Attachment #9089796 -
Attachment is obsolete: true
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2cc01a0d1d08
Revert the changes of bug 1577659 for the <statuspanel>. r=mkmelin DONTBUILD
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 70.0
Comment 7•5 years ago
|
||
Too bad, got landed with wrong reviewer.
You need to log in
before you can comment on or make changes to this bug.
Description
•