1578148 - Editing message tag colors not functioning correctly in V68

Status: VERIFIED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Matt]

Editing message colors appears to be broken wit the message "A tag with this name already exists" appearing when you save the color change.

The issue was raised in support, but I can reproduce it in Thunderbird 68 64Bit using the steps to reproduce given in the support topic.

Right click on a message title -> tag -> manage tags
Double click or click on a tag and edit.
Select a new colour and click on the ok

I get the message: 'A tag with that name already exits'

@Wayne. sfhowes mentions in the support thread that the issue is also with 69beta, I can not find anything existing in Bugzilla, or discourse for that matter, so have filed this bug. Please dup if you are aware of anything.

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks for filing, it's the first time I see this issue. BTW, easily confirmed.

Comment 2

[Jorg K (CEST = GMT+2)]

And if I edit the name and click OK, nothing happens :-(

Alice, can you find the regression for us. I'm pretty sure this worked when I was working on tag colours in bug 1497041 back in March 2019.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a240e0e27ce5c54a13857b4046f797eff255a4c4&tochange=ea892780482c5941b4df1b179cd6b92c681d8757
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=74be8815ccfce81f1ca6568f8cfebfc847a83ba2&tochange=bdaf1b36c44275dd4f027b4a4c30afed86cdfe13

Comment 4

[Jorg K (CEST = GMT+2)]

Sigh, more of bug 1541789 :-(

Comment 5

[Jorg K (CEST = GMT+2)]

Hey, Alice, thank you so much, that really helps!

Comment 6

[sfhowes]

Support reference, including workaround:
https://support.mozilla.org/en-US/questions/1267718

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: 1578148-tag-edit.patch

OK, this fixes the edit. It also fixes "New" when the panel doesn't close.

One issue left: Edit works, but the value in the list isn't updated. Aceman will take over.

Comment 8

[Jorg K (CEST = GMT+2)]

Attachment: 1578148-tag-edit.patch (v2)

Comment 9

[Jorg K (CEST = GMT+2)]

Attachment: 1578148-tag-edit.patch (v2b)

Comment 10

[Jorg K (CEST = GMT+2)]

Attachment: 1578148-tag-edit.patch

That fixes it. Aceman can review.

Comment 11

[Jorg K (CEST = GMT+2)]

Attachment: 1578148-tag-edit.patch (v3b)

Same patch but with querySelector instead of firstChild.

Comment 12

[:aceman]

Comment on attachment 9089905 [details] [diff] [review]
1578148-tag-edit.patch (v3b)

Review of attachment 9089905 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you, this works nicely now.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/86e0e08f619f
Fix various problems in tag add/edit. r=aceman DONTBUILD

Comment 14

[Jorg K (CEST = GMT+2)]

Comment on attachment 9089905 [details] [diff] [review]
1578148-tag-edit.patch (v3b)

We'll fix this for TB 68.1.

Comment 15

[Jorg K (CEST = GMT+2)]

TB 68.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/5370a455575f63731db921090fed9fe98a72c839

Comment 16

[Jorg K (CEST = GMT+2)]

Working in 68.1.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/37dcd837fe67
Follow-up: No need to pass 'event' explicitly. r=me

Comment 18

[Jorg K (CEST = GMT+2)]

Follow-up:
https://hg.mozilla.org/releases/comm-beta/rev/40654a3212fcbed521b373b5eb5c6c3c4e3d5c6c
https://hg.mozilla.org/releases/comm-esr68/rev/7ba590f93835054defb53f712f44de383b1d65f0