1578149 - Group `nsPlainTextSerializer`'s indentation members in common struct

Status: RESOLVED FIXED

(Core :: DOM: Serializers, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578149: part 1) Add `nsPlainTextSerializer::Indentation`. r=hsivonen

In order to encapsulate the indentation related members.

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578149: part 2) Simplify code in `nsPlainTextSerializer::Write`. r=hsivonen

Depends on D44346

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578149: part 3) Move whitespace triming out of `OutputQuotesAndIndent`. r=hsivonen

Whitespace triming was used by only one caller, so it deserves to live
outside. Additionally, this defines the method name more precisely.

Depends on D44347

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578149: part 4) Move truncating `mIndentation.mHeader` out of `CreateQuotesAndIndent`. r=hsivonen

Makes the method name more accurate.

Depends on D44348

Comment 5

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578149: part 5) Bundle resetting `mIndentation.mHeader` and `mCurrentLineContent`. r=hsivonen

Depends on D44349

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/73bbd2dfec98
part 1) Add `nsPlainTextSerializer::Indentation`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/e6a2035efc36
part 2) Simplify code in `nsPlainTextSerializer::Write`.  r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/ebdf7c03ad58
part 3) Move whitespace triming out of `OutputQuotesAndIndent`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/5712af8379c5
part 4) Move truncating `mIndentation.mHeader` out of `CreateQuotesAndIndent`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/bb67417b6f51
part 5) Bundle resetting `mIndentation.mHeader` and `mCurrentLineContent`. r=hsivonen

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/73bbd2dfec98
https://hg.mozilla.org/mozilla-central/rev/e6a2035efc36
https://hg.mozilla.org/mozilla-central/rev/ebdf7c03ad58
https://hg.mozilla.org/mozilla-central/rev/5712af8379c5
https://hg.mozilla.org/mozilla-central/rev/bb67417b6f51