1578188 - Remove redundant code by extending `nsPlainTextSerializer::OutputManager`

Status: RESOLVED FIXED

(Core :: DOM: Serializers, enhancement)

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578188: part 1) Remove `outputQuotes` variable for clarity. r=hsivonen

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578188: part 2) Use default constructor for `CurrentLineContent`. r=hsivonen

Simplifies a following refactoring.

Depends on D44382

Comment 3

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578188: part 3) Add `nsPlainTextSerializer::CurrentLine`. r=hsivonen

Depends on D44383

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578188: part 4) Move `ResetCurrentLineContentAndIndentationHeader` to `CurrentLine::ResetContentAndIndentationHeader`. r=hsivonen

Depends on D44384

Comment 5

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578188: part 5) Move `CreateQuotesAndIndent` to `CurrentLine`. r=hsivonen

Depends on D44385

Comment 6

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1578188: part 6) Overload `OutputManager::Append`. r=hsivonen

Depends on D44386

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8a4d4ed79a9
part 1) Remove `outputQuotes` variable for clarity. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/0e7556fc889c
part 2) Use default constructor for `CurrentLineContent`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/0a17895a7d02
part 3) Add `nsPlainTextSerializer::CurrentLine`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/b223bab23bb8
part 4) Move `ResetCurrentLineContentAndIndentationHeader` to `CurrentLine::ResetContentAndIndentationHeader`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/4cc132dea3cb
part 5) Move `CreateQuotesAndIndent` to `CurrentLine`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/85703e85e461
part 6) Overload `OutputManager::Append`. r=hsivonen

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d8a4d4ed79a9
https://hg.mozilla.org/mozilla-central/rev/0e7556fc889c
https://hg.mozilla.org/mozilla-central/rev/0a17895a7d02
https://hg.mozilla.org/mozilla-central/rev/b223bab23bb8
https://hg.mozilla.org/mozilla-central/rev/4cc132dea3cb
https://hg.mozilla.org/mozilla-central/rev/85703e85e461