1578253 - Perma browser_tabCloseProbes.js | application crashed [@ (anonymous namespace)::internal_JSHistogram when Gecko version increases to 72 on 2019-10-21

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Raul Gurzau (:RaulG)]

[Tracking Requested - why for this release]:

Version increase simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=264549523&resultStatus=testfailed%2Cbusted%2Cexception&revision=b8832c913b1c7150d74456e803a49ebe41d376f2

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264549523&repo=try&lineNumber=18634

Log snippet:
[task 2019-09-02T11:47:09.067Z] 11:47:09 INFO - zombiecheck | Checking for orphan process with PID: 1874
[task 2019-09-02T11:47:09.067Z] 11:47:09 INFO - mozcrash Copy/paste: /Users/cltbld/tasks/task_1567424129/build/macosx64-minidump_stackwalk /var/folders/f9/94z6mgb923sbz1gh96n2yq_8000017/T/tmpVP3e8J.mozrunner/minidumps/B8CF60B6-DFC9-449E-B5C7-86A19BBDE3F4.dmp /Users/cltbld/tasks/task_1567424129/build/symbols
[task 2019-09-02T11:47:18.706Z] 11:47:18 INFO - mozcrash Saved minidump as /Users/cltbld/tasks/task_1567424129/build/blobber_upload_dir/B8CF60B6-DFC9-449E-B5C7-86A19BBDE3F4.dmp
[task 2019-09-02T11:47:18.706Z] 11:47:18 INFO - mozcrash Saved app info as /Users/cltbld/tasks/task_1567424129/build/blobber_upload_dir/B8CF60B6-DFC9-449E-B5C7-86A19BBDE3F4.extra
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO - PROCESS-CRASH | browser/base/content/test/tabs/browser_tabCloseProbes.js | application crashed [@ (anonymous namespace)::internal_JSHistogram_Clear(JSContext*, unsigned int, JS::Value*)]
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO - Crash dump filename: /var/folders/f9/94z6mgb923sbz1gh96n2yq_8000017/T/tmpVP3e8J.mozrunner/minidumps/B8CF60B6-DFC9-449E-B5C7-86A19BBDE3F4.dmp
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO - Operating system: Mac OS X
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO - 10.14.5 18F132
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO - CPU: amd64
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO - family 6 model 69 stepping 1
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO - 4 CPUs
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO -
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO - GPU: UNKNOWN
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO -
[task 2019-09-02T11:47:18.898Z] 11:47:18 INFO - Crash reason: EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - Crash address: 0x0
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - Process uptime: 303 seconds
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO -
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - Thread 0 (crashed)
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - 0 XUL!(anonymous namespace)::internal_JSHistogram_Clear(JSContext*, unsigned int, JS::Value*) [TelemetryHistogram.cpp:b8832c913b1c7150d74456e803a49ebe41d376f2 : 1992 + 0x9b]
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rax = 0x000000011969afbe rdx = 0x0000000000000000
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rcx = 0x000000010db71de8 rbx = 0x000000011f75b700
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rsi = 0x00000000000120a8 rdi = 0x00007fff8e9b9028
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rbp = 0x00007ffee2104c40 rsp = 0x00007ffee2104b10
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - r8 = 0x00000000000130a8 r9 = 0x00007fff8e9b9048
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - r10 = 0x0000000000000000 r11 = 0x00007fff8e9b9040
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - r12 = 0x000000011f22e950 r13 = 0x00007ffee2104b78
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - r14 = 0x0000000000000f9c r15 = 0x000000011054f158
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rip = 0x00000001169a2918
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - Found by: given as instruction pointer in context
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - 1 XUL!CallJSNative(JSContext*, bool ()(JSContext, unsigned int, JS::Value*), JS::CallArgs const&) [Interpreter.cpp:b8832c913b1c7150d74456e803a49ebe41d376f2 : 447 + 0x12]
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rbp = 0x00007ffee2104cc0 rsp = 0x00007ffee2104c50
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rip = 0x0000000116c3ca39
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - Found by: previous frame's frame pointer
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - 2 XUL!js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) [Interpreter.cpp:b8832c913b1c7150d74456e803a49ebe41d376f2 : 539 + 0xb]
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rbp = 0x00007ffee2104d60 rsp = 0x00007ffee2104cd0
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rip = 0x0000000116c3c2e8
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - Found by: previous frame's frame pointer
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - 3 XUL!Interpret(JSContext*, js::RunState&) [Interpreter.cpp:b8832c913b1c7150d74456e803a49ebe41d376f2 : 598 + 0x8]
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rbp = 0x00007ffee21052c0 rsp = 0x00007ffee2104d70
[task 2019-09-02T11:47:18.899Z] 11:47:18 INFO - rip = 0x0000000116c314d3
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - Found by: previous frame's frame pointer
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - 4 XUL!js::RunScript(JSContext*, js::RunState&) [Interpreter.cpp:b8832c913b1c7150d74456e803a49ebe41d376f2 : 424 + 0xb]
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - rbp = 0x00007ffee2105310 rsp = 0x00007ffee21052d0
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - rip = 0x0000000116c2725c
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - Found by: previous frame's frame pointer
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - 5 XUL!js::InternalCallOrConstruct(JSContext*, JS::CallArgs const&, js::MaybeConstruct) [Interpreter.cpp:b8832c913b1c7150d74456e803a49ebe41d376f2 : 567 + 0x8]
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - rbp = 0x00007ffee21053b0 rsp = 0x00007ffee2105320
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - rip = 0x0000000116c3c264
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - Found by: previous frame's frame pointer
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - 6 XUL!<name omitted> [Interpreter.cpp:b8832c913b1c7150d74456e803a49ebe41d376f2 : 610 + 0x8]
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - rbp = 0x00007ffee21053d0 rsp = 0x00007ffee21053c0
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - rip = 0x0000000116c3d32d
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - Found by: previous frame's frame pointer
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - 7 XUL!js::CallSelfHostedFunction(JSContext*, JS::Handle<js::PropertyName*>, JS::Handle<JS::Value>, js::AnyInvokeArgs const&, JS::MutableHandle<JS::Value>) [SelfHosting.cpp:b8832c913b1c7150d74456e803a49ebe41d376f2 : 1658 + 0x17]
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - rbp = 0x00007ffee2105450 rsp = 0x00007ffee21053e0
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - rip = 0x0000000116fb102e
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - Found by: previous frame's frame pointer
[task 2019-09-02T11:47:18.900Z] 11:47:18 INFO - 8 XUL!js::jit::InterpretResume(JSContext*, JS::Handle<JSObject*>, JS::Handle<JS::Value>, JS::Handle<js::PropertyName*>, JS::MutableHandle<JS::Value>) [VMFunctions.cpp:b8832c913b1c7150d74456e803a49ebe41d376f2 : 980 + 0xb]

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1578253 - Bump expiry on FX_TAB_CLOSE_* probes to Firefox 76. data-review=chutten, r?nhnt11

This also removes GeckoView and Fennec on this probe since they are never used
on those browsers.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Data review request

Comment 3

[Chris H-C :chutten]

Comment on attachment 9098909 [details]
Data review request

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Histograms.json](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Histograms.json) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 76.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

    Is the data collection request for default-on or default-off?

Default on for pre-release channels only.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :mconley is responsible for renewing or removing the collection before it expires in Firefox 76.

---
Result: datareview+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/888092d46de7
Bump expiry on FX_TAB_CLOSE_* probes to Firefox 76. data-review=chutten, r=nhnt11

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/888092d46de7