1578266 - Perma browser_permissions_event_telemetry.js | Uncaught exception - at browser_permissions_event_telemetry.js:43 - TypeError: events is undefined when Gecko version increases to 72 on 2019-10-21

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P1)

Description

[Raul Gurzau (:RaulG)]

[Tracking Requested - why for this release]:

Version increase simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=264549531&resultStatus=testfailed%2Cbusted%2Cexception&revision=b8832c913b1c7150d74456e803a49ebe41d376f2

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=264549531&repo=try&lineNumber=2109

Log snippet:

[task 2019-09-02T11:38:57.787Z] 11:38:57 INFO - TEST-START | browser/base/content/test/permissions/browser_permissions_event_telemetry.js
[task 2019-09-02T11:38:57.787Z] 11:38:57 INFO - GECKO(1664) | ++DOCSHELL 0x11ad57000 == 2 [pid = 1668] [id = {16bfff19-3805-7449-96ec-4625e2a35aa0}]
[task 2019-09-02T11:38:57.787Z] 11:38:57 INFO - GECKO(1664) | ++DOMWINDOW == 5 (0x12253e3e0) [pid = 1668] [serial = 10] [outer = 0x0]
[task 2019-09-02T11:38:57.788Z] 11:38:57 INFO - GECKO(1664) | ++DOMWINDOW == 6 (0x11ac5dc00) [pid = 1668] [serial = 11] [outer = 0x12253e3e0]
[task 2019-09-02T11:38:57.816Z] 11:38:57 INFO - GECKO(1664) | --DOCSHELL 0x12d645000 == 5 [pid = 1667] [id = {3fc91b16-fee4-344b-ba72-cc1bbbcbe8d0}] [url = https://example.com/browser/browser/base/content/test/permissions/permissions.html]
[task 2019-09-02T11:38:57.816Z] 11:38:57 INFO - GECKO(1664) | --DOCSHELL 0x11e927000 == 4 [pid = 1667] [id = {8f05814e-2bd0-5740-9fe9-fd8fa90da3de}] [url = https://example.com/browser/browser/base/content/test/permissions/permissions.html]
[task 2019-09-02T11:38:57.816Z] 11:38:57 INFO - GECKO(1664) | --DOCSHELL 0x11e90a800 == 3 [pid = 1667] [id = {a0f87b58-1d54-5244-b4c0-15c4a17abec9}] [url = https://example.com/browser/browser/base/content/test/permissions/permissions.html]
[task 2019-09-02T11:38:57.816Z] 11:38:57 INFO - GECKO(1664) | --DOCSHELL 0x1223eb000 == 2 [pid = 1667] [id = {0f633ab1-2f90-ef4a-92fc-fac3a5b4c294}] [url = https://example.com/browser/browser/base/content/test/permissions/permissions.html]
[task 2019-09-02T11:38:57.816Z] 11:38:57 INFO - GECKO(1664) | --DOCSHELL 0x1223e5800 == 1 [pid = 1667] [id = {70c7809a-a12b-0342-9495-e29d11e1a1d8}] [url = about:blank]
[task 2019-09-02T11:38:57.954Z] 11:38:57 INFO - GECKO(1664) | --DOMWINDOW == 3 (0x10ffcf200) [pid = 1673] [serial = 1] [outer = 0x0] [url = https://example.com/browser/browser/base/content/test/permissions/browser_autoplay_blocked.html]
[task 2019-09-02T11:38:57.955Z] 11:38:57 INFO - GECKO(1664) | --DOCSHELL 0x128409800 == 0 [pid = 1673] [id = {44e5bce0-c747-2b4b-8077-029d2c205220}] [url = https://example.com/browser/browser/base/content/test/permissions/browser_autoplay_blocked.html]
[task 2019-09-02T11:38:57.955Z] 11:38:57 INFO - GECKO(1664) | ++DOMWINDOW == 7 (0x1225c9c00) [pid = 1668] [serial = 12] [outer = 0x12253e3e0]
[task 2019-09-02T11:38:57.955Z] 11:38:57 INFO - GECKO(1664) | [Child 1670, Main Thread] WARNING: '!window', file /builds/worker/workspace/build/src/dom/cache/CacheStorage.cpp, line 575
[task 2019-09-02T11:38:58.257Z] 11:38:58 INFO - GECKO(1664) | --DOMWINDOW == 16 (0x127f3f020) [pid = 1667] [serial = 1] [outer = 0x0] [url = about:blank]
[task 2019-09-02T11:38:58.257Z] 11:38:58 INFO - GECKO(1664) | --DOMWINDOW == 15 (0x127f3f980) [pid = 1667] [serial = 12] [outer = 0x0] [url = https://example.com/browser/browser/base/content/test/permissions/permissions.html]
[task 2019-09-02T11:38:58.257Z] 11:38:58 INFO - GECKO(1664) | --DOMWINDOW == 14 (0x127f3f7a0) [pid = 1667] [serial = 9] [outer = 0x0] [url = https://example.com/browser/browser/base/content/test/permissions/permissions.html]
[task 2019-09-02T11:38:58.257Z] 11:38:58 INFO - GECKO(1664) | --DOMWINDOW == 13 (0x127f3f5c0) [pid = 1667] [serial = 6] [outer = 0x0] [url = https://example.com/browser/browser/base/content/test/permissions/permissions.html]
[task 2019-09-02T11:38:58.257Z] 11:38:58 INFO - GECKO(1664) | --DOMWINDOW == 12 (0x127f3f200) [pid = 1667] [serial = 3] [outer = 0x0] [url = https://example.com/browser/browser/base/content/test/permissions/permissions.html]
[task 2019-09-02T11:38:58.424Z] 11:38:58 INFO - TEST-INFO | started process screencapture
[task 2019-09-02T11:38:58.584Z] 11:38:58 INFO - TEST-INFO | screencapture: exit 0
[task 2019-09-02T11:38:58.585Z] 11:38:58 INFO - Buffered messages logged at 11:38:57
[task 2019-09-02T11:38:58.585Z] 11:38:58 INFO - Entering test bound setup
[task 2019-09-02T11:38:58.585Z] 11:38:58 INFO - Leaving test bound setup
[task 2019-09-02T11:38:58.585Z] 11:38:58 INFO - Entering test bound testAccept
[task 2019-09-02T11:38:58.585Z] 11:38:58 INFO - Buffered messages logged at 11:38:58
[task 2019-09-02T11:38:58.585Z] 11:38:58 INFO - TEST-PASS | browser/base/content/test/permissions/browser_permissions_event_telemetry.js | Notification permission prompt was shown -
[task 2019-09-02T11:38:58.585Z] 11:38:58 INFO - Buffered messages finished
[task 2019-09-02T11:38:58.586Z] 11:38:58 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/permissions/browser_permissions_event_telemetry.js | Uncaught exception - at chrome://mochitests/content/browser/browser/base/content/test/permissions/browser_permissions_event_telemetry.js:43 - TypeError: events is undefined
[task 2019-09-02T11:38:58.586Z] 11:38:58 INFO - Stack trace:
[task 2019-09-02T11:38:58.586Z] 11:38:58 INFO - checkEventTelemetry@chrome://mochitests/content/browser/browser/base/content/test/permissions/browser_permissions_event_telemetry.js:43:3
[task 2019-09-02T11:38:58.586Z] 11:38:58 INFO - testAccept/<@chrome://mochitests/content/browser/browser/base/content/test/permissions/browser_permissions_event_telemetry.js:138:24
[task 2019-09-02T11:38:58.586Z] 11:38:58 INFO - asyncwithNewTab@resource://testing-common/BrowserTestUtils.jsm:141:24
[task 2019-09-02T11:38:58.586Z] 11:38:58 INFO - asynctestAccept@chrome://mochitests/content/browser/browser/base/content/test/permissions/browser_permissions_event_telemetry.js:135:26
[task 2019-09-02T11:38:58.586Z] 11:38:58 INFO - Tester_execTest/<@chrome://mochikit/content/browser-test.js:1350:34
[task 2019-09-02T11:38:58.586Z] 11:38:58 INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1385:11
[task 2019-09-02T11:38:58.586Z] 11:38:58 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1213:14
[task 2019-09-02T11:38:58.586Z] 11:38:58 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:805:67

Comment 1

[Johann Hofmann [:johannh]]

Let's have permissions event telemetry until 73 and then I think we can safely put it to rest.

Comment 2

[Johann Hofmann [:johannh]]

Attachment: request.md

Data review request for extension to 74, partially copied from the original request.

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Bug 1578266 - Extend permission event telemetry until 74. r=chutten

Comment 4

[Chris H-C :chutten]

Comment on attachment 9093233 [details]
request.md

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes. This collection is Telemetry so is documented in its definitions file [Events.yaml](https://hg.mozilla.org/mozilla-central/file/tip/toolkit/components/telemetry/Events.yaml) and the [Probe Dictionary](https://telemetry.mozilla.org/probe-dictionary/).

    Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

    If the request is for permanent data collection, is there someone who will monitor the data over time?

No. This collection will expire in Firefox 74.

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 3, Web Activity.

    Is the data collection request for default-on or default-off?

Default on for pre-release channels only.

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice?

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Yes. :johannh is responsible for renewing or removing the collection before it expires in Firefox 74.

---
Result: datareview+

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4279ae89b087
Extend permission event telemetry until 74. r=chutten

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/4279ae89b087

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with latest version increase simulation: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&revision=b30d003a9e626cc9ace7f954c0a5eebbb2d5c9cd