1578298 - [RTL] Fix protection details cog icon position

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Itiel]

Attachment: Screenshot

Comment 1

[Itiel]

Attachment: Bug 1578298 - Fix protection details cog icon position for RTL and merge 2 rules

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e13633b0be8
Fix protection details cog icon position for RTL and merge 2 rules r=johannh

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/4e13633b0be8

Comment 4

[Erica Wright [:ewright]]

This needs uplift to beta 70, I'll request for you.

Comment 5

[Erica Wright [:ewright]]

Comment on attachment 9089920 [details]
Bug 1578298 - Fix protection details cog icon position for RTL and merge 2 rules

Beta/Release Uplift Approval Request

• User impact if declined: In rtl builds an icon overlaps some text.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): small CSS patch adding an rtl rule.
• String changes made/needed: none

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9089920 [details]
Bug 1578298 - Fix protection details cog icon position for RTL and merge 2 rules

Fix for RTL issue for Skyline feature, fine for beta 10 uplift.

Comment 8

[Raul Gurzau (:RaulG)]

Got conflict while uplifting to beta:

raul@raul-VirtualBox ~/mozilla-unified beta(+3) $ hg graft -er 4e13633b0be8
grafting 564224:4e13633b0be8 "Bug 1578298 - Fix protection details cog icon position for RTL and merge 2 rules r=johannh"
merging browser/components/protections/content/protections.css
warning: conflicts while merging browser/components/protections/content/protections.css! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use 'hg resolve' and 'hg graft --continue')

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/322f9a02cb0a

Comment 10

[Itiel]

This seems to have been fixed in comment 9.

Comment 11

[Ciprian Georgiu, Desktop QA]

Reproduced the issue using an affected Nightly build from 2019-09-02, and by modifing the pref intl.uidirection;1.

This is verified fixed on latest Nightly 71.0a1 and Beta 70.0b10, under macOS 10.14, Win 10 x64 and Ubuntu 18.04 x64.