Closed Bug 1578300 Opened Last month Closed Last month

Insert Special Character does not work anymore

Categories

(Thunderbird :: Message Compose Window, defect)

defect
Not set

Tracking

(thunderbird_esr6869+ fixed, thunderbird70 fixed, thunderbird71 fixed)

RESOLVED FIXED
Thunderbird 71.0
Tracking Status
thunderbird_esr68 69+ fixed
thunderbird70 --- fixed
thunderbird71 --- fixed

People

(Reporter: nekrub2, Assigned: iann_bugzilla)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Until last week I could write in a mail the Swedish name Åke, using the insert special character function. When I click now on it to insert nothing happens.

Actual results:

When I click now on it to insert nothing happens. Choosing a second time insert special character doesn't open the pop-up any more.

Expected results:

I would have expected that with version 68.0 (32-Bit) this function would still work and I could insert a special character into the text.

Sorry, yes, that got broken in TB 68.0. We'll get it fixed for TB 68.1.

Status: UNCONFIRMED → NEW
Component: Mail Window Front End → Message Compose Window
Ever confirmed: true

using the insert special character function

How? and Where?

Flags: needinfo?(alice0775)

Write window. Click in body. Menu: Insert > Characters and Symbols ... Click "Insert". Nothing inserted. On the next attempt the menu doesn't even appear.

Thanks, Alice. Bug 1541789 strikes again. I thought that when looking through the code last night in comment #2, but didn't see anything obvious. But given to the strange behaviour that the panel doesn't come up a second time, maybe it's related to bug 1541144.

Ian, I see you more active lately. Any idea what has gone wrong here. It would affect SM, too.

Flags: needinfo?(iann_bugzilla)
Flags: needinfo?(iann_bugzilla)

Maybe something like this?

Attachment #9090061 - Flags: review?(jorgk)

Thank you so much, Ian. I must be blind:
https://searchfox.org/comm-central/rev/c373ead9a9833cc3ad6a09b8ca684d1653b22686/editor/ui/dialogs/content/EdInsertChars.xul#17
How did I not see that :-(

Your patch looks spot-on, I'll give it a whirl in a little while.

Comment on attachment 9090061 [details] [diff] [review]
Fix edinsertchars accept/close

Working, thank you.
Attachment #9090061 - Flags: review?(jorgk)
Attachment #9090061 - Flags: review+
Attachment #9090061 - Flags: approval-comm-esr68+
Attachment #9090061 - Flags: approval-comm-beta+
Target Milestone: --- → Thunderbird 71.0
Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/2e25ded35a1a
Fix dialogaccept/dialogcancel of 'Insert Special Character'. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED

Working in TB 68.1.

You need to log in before you can comment on or make changes to this bug.