Closed Bug 1578327 Opened 1 year ago Closed 11 months ago

Discard old profiler data just before streaming

Categories

(Core :: Gecko Profiler, task, P2)

task

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox71 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

Details

Attachments

(1 file)

Since all profiler data is now stored inside ProfileBuffer's BlocksRingBuffer, there is no real need to continuously discard old data during sampling (this was particularly useful to reclaim memory taken by old markers&payloads).

Instead, we can now just discard the old data once, just before starting to stream it to JSON.

Since all profiler data is now stored inside ProfileBuffer, there is no real
need to continuously discard old data during sampling (this was particularly
useful to reclaim memory taken by old markers&payloads).

Instead, we can now just discard the old data once, just before starting to
stream it to JSON.

Depends on D43431

Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f51875652f6f
Discard old data just before streaming - r=gregtatum

Thank you Bogdan. Luckily not a real issue, but it will require a bit of work to help the js hazard analyzer.

Flags: needinfo?(gsquelart)
Pushed by gsquelart@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/226b570cb964
Discard old data just before streaming - r=gregtatum
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.