1578327 - Discard old profiler data just before streaming

Status: RESOLVED FIXED

(Core :: Gecko Profiler, task, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Since all profiler data is now stored inside ProfileBuffer's BlocksRingBuffer, there is no real need to continuously discard old data during sampling (this was particularly useful to reclaim memory taken by old markers&payloads).

Instead, we can now just discard the old data once, just before starting to stream it to JSON.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1578327 - Discard old data just before streaming - r?gregtatum

Since all profiler data is now stored inside ProfileBuffer, there is no real
need to continuously discard old data during sampling (this was particularly
useful to reclaim memory taken by old markers&payloads).

Instead, we can now just discard the old data once, just before starting to
stream it to JSON.

Depends on D43431

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f51875652f6f
Discard old data just before streaming - r=gregtatum

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 21 changesets (Bug 1578327, Bug 1575448, Bug 1580091, Bug 1576554, Bug 1581049, Bug 1576551, Bug 1578329, Bug 1576555) for platform.cpp related bustage

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&fromchange=27afea20c396eaa2731fa6e705471b446c6683e6&tochange=9c10aac0356842219e95d1f6deb0bf7e7baed334&selectedJob=266985776

Backout link: https://hg.mozilla.org/integration/autoland/rev/9c10aac0356842219e95d1f6deb0bf7e7baed334

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=266985776&repo=autoland&lineNumber=53923

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you Bogdan. Luckily not a real issue, but it will require a bit of work to help the js hazard analyzer.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/226b570cb964
Discard old data just before streaming - r=gregtatum

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/226b570cb964