1578334 - NVDA reports confusing status to user when enabling or disabling ETP from the protections panel

Status: RESOLVED FIXED

(Firefox :: Protections UI, defect, P1)

Description

[Asa Dotzler [:asa]]

When disabling or enabling ETP, the screen reader user gets confusing announcements that suggest the operation didn't work, at least at first. A moment later the user gets a second announcement that the operation did work.

@jteh said:

1. In the panel, you toggle protection.
2. Focus returns to the protection button on the toolbar. However, the tooltip on the button hasn't been updated yet.
3. The tooltip updates. NVDA reports the updated tooltip.

Fixing this is going to require some kind of timing dance. We need to ensure the tooltip gets updated before the button gets focus after the panel is dismissed. That means either:

1. Updating the tooltip earlier.
2. Closing the panel when we do now and somehow delaying focus of the button.
3. Delaying closing of the panel until the tooltip updates, thus delaying return of focus to the button.

Comment 1

[(inactive) Nihanth Subramanya [:nhnt11]]

Seems like we could maybe artificially change the tooltip before the 500ms wait - Tim, could you comment on this?

Comment 2

[Tim Huang[:timhuang]]

I think we can update the tooltip before the 500ms wait. But, I got a little confused regarding the tooltip of the protection button which Asa mentioned. Did you mean the tooltip of the tracking protection icon or something else?

Comment 3

[Tim Huang[:timhuang]]

If you meant the tooltip of the tracking protection icon, I think we can immediately change it to the tooltip of the disabled protections when toggling to the off state before the 500ms wait. And same for toggling to ON state, we can change it to the tooltip of the 'No trackers detected' and it will get updated when the first onContentBlockingEvent happens.

Comment 4

[Asa Dotzler [:asa]]

I don't quite understand what's happening here and filed this bug with information from Jamie. Jamie, can you answer Tim's question?

Comment 5

[James Teh [:Jamie]]

Yes, we're referring to the tooltip of the tracking protection icon; i.e. the tooltip of #tracking-protection-icon-container.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 70 release - we can still accept a patch for this issue in 70, preferably next week for beta 11 or 12.

Comment 7

[Johann Hofmann [:johannh]]

Tim, did you intend to work on this? :)

Comment 8

[Tim Huang[:timhuang]]

I will work on this. I'll try to fix this if possible before next week.

Comment 9

[Tim Huang[:timhuang]]

Attachment: Bug 1578334 - Update the tooltip of the tracking protection icon when toggling the TP switch. r?nhnt11!

In order to show a correct tooltip after toggling the TP switch. We
update the tooltip of the tracking protection icon when toggling the TP
switch right before the 500 ms waiting.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8602fcecc75
Update the tooltip of the tracking protection icon when toggling the TP switch. r=nhnt11

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d8602fcecc75

Comment 12

[Tim Huang[:timhuang]]

Hi James,

Would you be able to verify if this issue been fixed? Thanks.

Comment 13

[Asa Dotzler [:asa]]

I can confirm that this is no longer confusing like it was. With today's Nightly build, now the screen reader communicates the proper state after switching from on to off and off to on.

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Can you request beta uplift? Thanks!

Comment 15

[James Teh [:Jamie]]

See comment 13.

Comment 16

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 9097322 [details]
Bug 1578334 - Update the tooltip of the tracking protection icon when toggling the TP switch. r?nhnt11!

Beta/Release Uplift Approval Request

• User impact if declined: Confusing feedback to screen-reader users when ETP is toggled.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch mainly moves some code to execute before some other code. Not too risky, verified by Asa in comment 13.
• String changes made/needed: None

Comment 17

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9097322 [details]
Bug 1578334 - Update the tooltip of the tracking protection icon when toggling the TP switch. r?nhnt11!

Fix for a11y issue for skyline feature, OK for uplift for beta 12.

Comment 18

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b3d633c3bb75