Closed
Bug 1578338
Opened 5 years ago
Closed 5 years ago
Add a middleware to freeze the Redux app when destroying the console panel
Categories
(DevTools :: Console, task, P3)
DevTools
Console
Tracking
(firefox72 fixed)
RESOLVED
FIXED
Firefox 72
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
Details
Attachments
(1 file)
We have a few test intermittent failures in the console that are due to requests not being able to reach the server because the connection was destroyed.
Since most of our communication to the server are done through actions, it seems like we could have a way to prevent any actions to be handled (via a middleware), in order to prevent those calls to the server once the panel's destroy
function was called.
Assignee | ||
Comment 1•5 years ago
|
||
The provided middleware needs to be added at the first position in the
redux store, and is then enabled by dispatching the FREEZE action.
We use it in the console, when the destroy function is being called.
Updated•5 years ago
|
Attachment #9089972 -
Attachment description: Bug 1578338 - Add a middleware to bypass any call to actions. r=Honza,jdescottes,rcaliman,davidwalsh. → Bug 1578338 - Add a middleware to bypass any call to actions. r=Honza,jdescottes.
Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e3abf144a9d5 Add a middleware to bypass any call to actions. r=jdescottes.
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox72:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 72
You need to log in
before you can comment on or make changes to this bug.
Description
•