Closed Bug 1578343 Opened 5 years ago Closed 4 years ago

[wpt-sync] Sync PR 18799 - [css-text] Handling trailing ideographic spaces as regular spaces

Categories

(Core :: Layout: Text and Fonts, task, P4)

Product:
Core
Component:
Layout: Text and Fonts
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
84 Branch
Tracking Flags:
Tracking Status
firefox84 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 18799 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/18799
Details from upstream follow.

Javier Fernandez <jfernandez@igalia.com> wrote:

[css-text] Handling trailing ideographic spaces as regular spaces

The CSS Text 3 specification states on its 'Phase II: Trimming and
Positioning' section:

https://www.w3.org/TR/css-text-3/#white-space-phase-2

3- A sequence at the end of a line (ignoring any intervening inline box
boundaries) of collapsible spaces (U+0020) and/or ideographic spaces
(U+3000) whose white-space value collapses spaces is removed.

4- If there remains any sequence of white space and/or ideographic spaces
(U+3000) at the end of a line: If white-space is set to pre-wrap, the UA
must hang this sequence. It may also visually collapse the character
advance widths of any that would otherwise overflow.

This CL tries to implement such behavior, since we were not considering
this kind of spaces in the hanging/collapsing logic.

Bug: 972952
Change-Id: Idb0aff05f7f423f5b62f5169177c0240917435a7
Reviewed-on: https://chromium-review.googlesource.com/1687411
WPT-Export-Revision: 02906301cc169a7dc40265cf949b746da624dc40

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Component: CSS Parsing and Computation → Layout: Text and Fonts

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 24 tests

Status Summary

Firefox

PASS: 14
FAIL: 10

Chrome

PASS: 15
FAIL: 9

Safari

PASS: 14
FAIL: 10

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-text/white-space/trailing-ideographic-space-005.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-text/white-space/trailing-ideographic-space-006.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-text/white-space/trailing-ideographic-space-008.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-text/white-space/trailing-ideographic-space-010.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-text/white-space/trailing-ideographic-space-011.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-text/white-space/trailing-ideographic-space-012.html: FAIL (Chrome: PASS, Safari: FAIL)
/css/css-text/white-space/trailing-ideographic-space-013.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-text/white-space/trailing-ideographic-space-014.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-text/white-space/trailing-ideographic-space-015.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-text/white-space/trailing-ideographic-space-016.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/251b42b73757 [wpt PR 18799] - [css-text] Handling trailing ideographic spaces as regular spaces, a=testonly https://hg.mozilla.org/integration/autoland/rev/5aacea5cf438 [wpt PR 18799] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/251b42b73757
https://hg.mozilla.org/mozilla-central/rev/5aacea5cf438

Status: REOPENED → RESOLVED
Closed: 5 years ago → 4 years ago
status-firefox84: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.