1578373 - The mouse isn't properly followed in the graphical part

Status: VERIFIED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect, P1)

Description

[Julien Wajsberg [:julienw]]

STR:

1. Record some profile from the performance tab in the devtools. Note: this is about the default (aka old) panel.
2. Hover with the mouse on top of the graphical part at the top of the window.
   => see that the vertical cursor doesn't follow the mouse properly, there's some translation.
3. Try to select a range.
   => the translation is still there.

I found that the problem is even worse when the devtools are docked to the right, and not too wide.

Comment 1

[Julien Wajsberg [:julienw]]

I reproduced on Mac and Linux.

Comment 2

[Gabi Cheta [:Gabi] Desktop QA]

Managed to reproduce the issue on Nightly 71.0a1 (2019-09-09) with MacOS 10.13.6.

• Regression results from mozregression:
• Last good revision: 91f7769b3d7ec17aa11f7a8ada7104f5b4cec38d
• First bad revision: 39e19afc797d310f568447eae7054789e641b591
• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=91f7769b3d7ec17aa11f7a8ada7104f5b4cec38d&tochange=39e19afc797d310f568447eae7054789e641b591

Comment 3

[Julien Wajsberg [:julienw]]

Thanks Gabi!
Looks like bug 1539979 regressed this, then.
Julian, any idea?

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1578373 - Stop using window.top in devtools/client/shared/widgets/Graphs.js

Comment 5

[Julian Descottes [:jdescottes]]

thanks for the ping!
In Graphs.js (https://searchfox.org/mozilla-central/rev/588814f2edddf0e132d77d326ddae50911e8bad1/devtools/client/shared/widgets/Graphs.js#109), the following code no longer returns the expected window when running in a content frame.

this._topWindow = this._window.top;

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e185d44f74f
Stop using window.top in devtools/client/shared/widgets/Graphs.js r=julienw

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/5e185d44f74f

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Is this something we should consider for Beta uplift?

Comment 9

[Julian Descottes [:jdescottes]]

Comment on attachment 9091919 [details]
Bug 1578373 - Stop using window.top in devtools/client/shared/widgets/Graphs.js

Beta/Release Uplift Approval Request

• User impact if declined: UI Bug when using the performance panel in DevTools
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: (adapted from the summary)

• open devtools
• dock devtools to the right
• select performance panel
• record a profile
• mouseover the profile to see the vertical cursor appear in the chart

ER: the vertical line should be exactly under the cursor
AR: the vertical line is either invisible or has an offset

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor javascript change
• String changes made/needed:

Comment 10

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with 71.0a1 (2019-09-22) on Windows 10x64, Ubuntu 16.04 and macOS 10.13.6

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9091919 [details]
Bug 1578373 - Stop using window.top in devtools/client/shared/widgets/Graphs.js

Minimal js patch which fixes a regression and was verified on Nightly, uplift appoved for 70 beta 9, thanks.

Comment 12

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d6318c213e71

Comment 13

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with 70.0b9 on Ubuntu 18.04, Windows 10x64 and macOS 10.13.6.