Closed Bug 1578391 Opened 3 years ago Closed 3 years ago

Fix various races during profiler shutdown.

Categories

(Core :: Gecko Profiler, defect, P3)

Product:
Core
Component:
Gecko Profiler
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla71
Tracking Flags:
Tracking Status
firefox71 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Bug 1578391 - Fix various races during profiler shutdown.
47 bytes, text/x-phabricator-request
Details | Review
No description provided.

I'm trying to make shutdown wait for the style system threads. This uncovers an
intermittent race where one of the unregistering functions get called before the
profiler has shot down, checks CorePS::Exists(), which returns true, but by the
time it acquires the lock the profiler has shot down already.

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6b190140c261
Fix various races during profiler shutdown. r=mstange

https://hg.mozilla.org/mozilla-central/rev/6b190140c261

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox71: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71

Thank you Emilio, good find!

Component: Performance → Gecko Profiler
You need to log in before you can comment on or make changes to this bug.