1578420 - Fix bogus test_reload in test_delay_update_webextension.js

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, task, P3)

Description

[Tomislav Jovanovic :zombie]

I found this while working on https://phabricator.services.mozilla.com/D44368#inline-270225

The test finishes before the runtime.reload() call takes effect, effectively testing nothing.

The await extension.awaitStartup() line is returning immediately because it's awaiting the already resolved promise from the first extension startup from the top of the test.

https://searchfox.org/mozilla-central/rev/e04021f2/toolkit/mozapps/extensions/test/xpcshell/test_delay_update_webextension.js#372

Adding a wait of 1 second leaves time for extension to restart and to send the "ready" message again.

Comment 1

[Tomislav Jovanovic :zombie]

Attachment: Bug 1578420 - Fix test_delay_update_webextension to actually wait for extension startup after restart

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62de619a3d75
Fix test_delay_update_webextension to actually wait for extension startup after restart r=robwu

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/62de619a3d75

Comment 4

[Miruna Curtean]

Hello,
Will this fix require manual validation or is it covered by automated tests? If yes, please provide some steps to reproduce in order to correctly test it and also, please set the "qe-verify+" flag.
Otherwise, could the "qe-verify-" flag be added? Thank you.

Comment 5

[Tomislav Jovanovic :zombie]

Not needed, thanks.

For future reference, test-only changes can't have a visible effect in product, so manual verification is not possible, and so obviously never needed.

Comment 6

[Miruna Curtean]

It did seem rather obvious but we needed the confirmation and for the issue to have that flag, otherwise it would continue to show up in our queries containing work to be done.
Thank you for the details.