Closed Bug 1578426 Opened 2 years ago Closed 2 years ago

Rename Inspector.target to currentTarget

Categories

(DevTools :: Inspector, enhancement, P1)

enhancement

Tracking

(firefox71 fixed)

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

(Whiteboard: dt-fission dt-fission-m1)

Attachments

(2 files)

In order to better align the fact that a given toolbox may have its top level target to change to another instance whenever the inspected target navigates to another process,
we should rename existing target attributes we have in the codebase to currentTarget.
But we should do that only if the JS Class the attribute is on can change to another target.
In a few places, like WebConsoleConnectionProxy, a given class instance is bound to only one target and will be destroyed if the related target is destroyed or navigates.

Here, this bug is specific to the Inspector class and its target attribute:
https://searchfox.org/mozilla-central/rev/e04021f29e6d8a37753ba2b510432315ce05a8d7/devtools/client/inspector/inspector.js#482-494
While we are at it, we may rename this other target attribute:
https://searchfox.org/mozilla-central/rev/e04021f29e6d8a37753ba2b510432315ce05a8d7/devtools/client/inspector/rules/rules.js#302-304

Whiteboard: dt-fission

Rename this attribute to better significate that the target is
changing over time when the debugged target navigates to another process.

Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f90d2f754473
Rename Inspector.target to Inspector.currentTarget. r=pbro
https://hg.mozilla.org/integration/autoland/rev/c6509b260bf4
Rename CssRuleView.target to currentTarget. r=pbro
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Whiteboard: dt-fission → dt-fission dt-fission-m1
You need to log in before you can comment on or make changes to this bug.