Open Bug 1578428 Opened 3 months ago Updated 3 months ago

Duplicated (old) dependency for rand_core crate

Categories

(Testing :: geckodriver, defect, P3)

Version 3
defect

Tracking

(Not tracked)

People

(Reporter: whimboo, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

When compiling geckodriver the following two dependencies are getting imported twice:

   Compiling base64 v0.10.0
   Compiling base64 v0.9.3
   Compiling rand_core v0.3.1
   Compiling rand_core v0.4.0

To reduce the file size of geckodriver, we should try to eliminate those old versions, which are also still vendored in the tree.

Andreas, not sure how complicated that is but I think it will be fine for the 0.26 release.

Flags: needinfo?(ato)

The explanation is that two separate crates have dependencies on
two different versions of the same crate. It’s possible to figure
this out using cargo tree.

Flags: needinfo?(ato)

(My previous comment got mangled by Bugzilla “helpfully” offering
to attach the paste as an attachment, accidentally posting the
unfinished comment at the same time. For that reason I’ve deleted
it and am reposting it.)

For base64 it seems to be a case of plist depending on an exact
earlier version, and this can by the looks of it be resolved by
upgrading to a more recent plist version:
https://github.com/ebarnard/rust-plist/blob/master/Cargo.toml

rand_core is a bit more complicated (see attachment) and is subject
to tokio-fs and rand_chacha. I don’t entirely understand how rand_core
0.3.1 can depend on rand_core 0.4.0, so this may need more
investigation. It’s worth just trying to upgrade warp/hyper to see
if that resolves it on its own.

I’ve upgraded plist over in bug 1520585.

Cool. So updating the summary that rand_core only remains. Thanks!

Summary: Duplicated (old) dependencies for base64 and rand_core crates → Duplicated (old) dependency for rand_core crate

The priority flag is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(hskupin)
Flags: needinfo?(hskupin)
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.