1578474 - cope with MozillaOnline builds sending unexpected system capabilities strings

Status: RESOLVED MOVED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect)

Description

[[e-mail] (:bhearsum)]

I just noticed that some mozillaonline builds are sending update URLs such as:
https://aus5.mozilla.org/update/6/firefox/68.0.2/20190813150448/winnt_x86_64-msvc-x64/zh-cn/release-cck-mainwinfull-mozillaonline/windows_nt%206.1.1.0.7601%20%28x64%29/iset:sse4_2%2Cmem:16341/mozillaonline/2019.7/update.xml

Because the strings in the system capabilities section are lowercase (iset:sse4_2%2Cmem:16341), our parsing is not working correctly: https://github.com/mozilla/balrog/blob/dfd356a96820a88f05195ec5cd8d536fc5830e8d/auslib/web/public/client.py#L38

Which causes exceptions like: invalid literal for int() with base 10: 'mem:16341'

We should adjust our parsing logic to lowercase those strings before comparison, but it would be good to sync up whatever is creating those mozillaonline URLs with the rest of the client side code. I'm not sure who the right person to contact about this - Robert or Mike, do you know?

Comment 1

[Robert Strong (they/them - no direct email)]

I have no idea... hopefully Mike knows.

Comment 2

[Mike Kaply [:mkaply]]

That's really odd. I have no idea why it would do that. NIing hector.

Comment 3

[Nick Thomas [:nthomas] (UTC+12)]

The lower case %BUILD_TARGET% of winnt_x86_64-msvc-x64 is also problematic. Balrog does a case-sensitive match, and doesn't find anything when it expecting to be asked about WINNT_x86_64-msvc-x64.

EDIT: and zh-cn instead of zh-CN, firefox instead of Firefox, and any matching on %OS_VERSION%.

Whatever is calling lower() on the whole url should be fixed up.

Comment 4

[Hector Zhao [:hectorz]]

I don't think we've ever touched any aspects of desktop Firefox's update mechanism at Beijing office.

How many requests like this are we seeing? Is it limited to e.g. certain province of China? Maybe the urls are lowercased by some kind of MITM proxy?

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Nick Thomas [:nthomas] (UTC+12) from comment #3)

The lower case %BUILD_TARGET% of winnt_x86_64-msvc-x64 is also problematic. Balrog does a case-sensitive match, and doesn't find anything when it expecting to be asked about WINNT_x86_64-msvc-x64.

EDIT: and zh-cn instead of zh-CN, firefox instead of Firefox, and any matching on %OS_VERSION%.

Whatever is calling lower() on the whole url should be fixed up.

That's a really good point, this is going to be pretty to fix up properly.

(In reply to Hector Zhao [:hectorz] from comment #4)

I don't think we've ever touched any aspects of desktop Firefox's update mechanism at Beijing office.

How many requests like this are we seeing? Is it limited to e.g. certain province of China? Maybe the urls are lowercased by some kind of MITM proxy?

Roughly 1,000 in total, and only a handful per day - so not that many in the grand scheme of things.

Comment 6

[[e-mail] (:bhearsum)]

Moved to https://github.com/mozilla-releng/balrog/issues/1110