1578489 - Firefox Installer ICON uses old logo

Status: RESOLVED FIXED

(Firefox :: Installer, defect, P1)

Description

[Knowguy]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/78.0.3879.0 Safari/537.36 Edg/78.0.249.1

Steps to reproduce:

1). Download candidate build (Such as Beta 70).
2). Installer icon is using the old logo as of version 70.
3). Look at EXE files located here: https://ftp.mozilla.org/pub/firefox/candidates/70.0b3-candidates/build3/

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

To clarify, do you mean the icon for the installer itself (the one with the Firefox logo being taken out of a box), or a different one?

Comment 3

[Knowguy]

(In reply to Matt Howell (he/him) [:mhowell] from comment #2)

To clarify, do you mean the icon for the installer itself (the one with the Firefox logo being taken out of a box), or a different one?

Yes that is exactly what I am mentioning. Sorry for the wording.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Okay, thank you, just needed to make sure.

Stephen, can you look into getting an updated installer icon with the new release channel logo?

Comment 5

[Stephen Horlander [:shorlander]]

Attachment: Firefox Installer.ico

Comment 6

[Stephen Horlander [:shorlander]]

(In reply to Matt Howell (he/him) [:mhowell] from comment #4)

Okay, thank you, just needed to make sure.

Stephen, can you look into getting an updated installer icon with the new release channel logo?

Attached an updated installer icon.

Comment 7

[Molly Howell (she/her) (mostly inactive)]

Thanks, that looks perfect! I'll get a patch ready.

Comment 8

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1578489 - New Windows installer icon. r=agashlin

This patch includes:

• The new icon file itself
• A modified Win32 SFX binary with the icon resource replaced and no other changes
• A rebuilt ARM64 binary (because rebuilding it is just as easy as resource hacking it)
• And I also took the opportunity to update the VC project to the 2019 toolchain
  and removed the requirement for a particular Windows 10 SDK version.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b980f38ac7a
New Windows installer icon. r=agashlin

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1b980f38ac7a

Comment 11

[Knowguy]

Will this be uplifted to Beta 70 as this is the release that is planned on having the new logo at release?

Comment 12

[Molly Howell (she/her) (mostly inactive)]

That's a good idea, I'll request that uplift.

Comment 13

[Molly Howell (she/her) (mostly inactive)]

Comment on attachment 9094718 [details]
Bug 1578489 - New Windows installer icon. r=agashlin

Beta/Release Uplift Approval Request

• User impact if declined: Bug 1570397 updated the application icons, but not the installer icon, so they're mismatched.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is just swapping out an icon resource.
• String changes made/needed:

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9094718 [details]
Bug 1578489 - New Windows installer icon. r=agashlin

New icon, let's uplift.

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/releases/mozilla-beta/rev/47397a99bd0a

Comment 16

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Binary parts hadn't been stripped in previous landing.

Backout: https://hg.mozilla.org/releases/mozilla-beta/rev/2f8e434edfbe5910019bdb29e8a02352864e9d35
Reland: https://hg.mozilla.org/releases/mozilla-beta/rev/ac26f9b1e8ef8cd043d79109fd32975daa908a4d