1578494 - Iron out keyboard audit rules.

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, defect, P1)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

There are a couple of false positives that need to be taken care while the keyboard checks are still in beta. This is a bug that collects them all:

• remove combobox option from keyboard interactive list since it's does not need to be focusable
• PARENT_MENUITEM should be in interactive list

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

"Clickable elements must be focusable and should have interactive semantics" seems to happen for text leafs inside anchors because they have "jump" action

add a check if it's a text leaf - bail
remove showlongdesc action from list
check if count is > 0

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1578494 - when checking for mouse only interactivity, add additional checks for text leafs and showlongdesc actions. r=nchevobbe

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/449f9cdc5737
when checking for mouse only interactivity, add additional checks for text leafs and showlongdesc actions. r=nchevobbe

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Valid label accessibles that have a proper relationship with another accessible also have a click action that puts focus on the related element. This needs to be taken into account.

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/449f9cdc5737

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1578494 - include ROLE_PARENT_MENUITEM (currently selected/visible menu item) into a set of interactive roles. r=nchevobbe

Comment 7

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1578494 - separate accessible roles into the ones that are expected to be interactive from keyboard accessible ones, better account for ARIA comboboxes and listboxes. r=nchevobbe

Depends on D45214

Comment 8

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1578494 - ignore valid labels with "label for" relations as they are clickable. r=nchevobbe

Depends on D45215

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1578494 - ignore images inside anchors for semantic check as they get a propagated jump action. r=nchevobbe

Depends on D45216

Comment 10

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: Bug 1578494 - make MOUSE_INTERACTIVE_ONLY failure check less strict and only look at click action. r=nchevobbe

Depends on D45217

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4db4134ce37f
include ROLE_PARENT_MENUITEM (currently selected/visible menu item) into a set of interactive roles. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/1c1cce6858bf
separate accessible roles into the ones that are expected to be interactive from keyboard accessible ones, better account for ARIA comboboxes and listboxes. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f27848276c11
ignore valid labels with "label for" relations as they are clickable. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/a938a9681091
ignore images inside anchors for semantic check as they get a propagated jump action. r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/10e7e29e4357
make MOUSE_INTERACTIVE_ONLY failure check less strict and only look at click action. r=nchevobbe

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/4db4134ce37f
https://hg.mozilla.org/mozilla-central/rev/1c1cce6858bf
https://hg.mozilla.org/mozilla-central/rev/f27848276c11
https://hg.mozilla.org/mozilla-central/rev/a938a9681091
https://hg.mozilla.org/mozilla-central/rev/10e7e29e4357

Comment 13

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 9091494 [details]
Bug 1578494 - make MOUSE_INTERACTIVE_ONLY failure check less strict and only look at click action. r=nchevobbe

Beta/Release Uplift Approval Request

• User impact if declined: Developers auditing websites for keyboard accessibility will have too many false positives.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk as its covered by tests, small changes to keyboard accessibility audit rules.
• String changes made/needed: None

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 9090775 [details]
Bug 1578494 - when checking for mouse only interactivity, add additional checks for text leafs and showlongdesc actions. r=nchevobbe

Better support for a11y checks. OK for beta uplift.

Comment 15

[Andrei Ciure[:aciure]]

Merge conflict when trying to uplift to beta:

grafting 565235:1c1cce6858bf "Bug 1578494 - separate accessible roles into the ones that are expected to be interactive from keyboard accessible ones, better account for ARIA comboboxes and listboxes. r=nchevobbe"
merging devtools/server/actors/accessibility/audit/keyboard.js
merging devtools/server/tests/browser/browser_accessibility_keyboard_audit.js
merging devtools/server/tests/browser/doc_accessibility_keyboard_audit.html
warning: conflicts while merging devtools/server/tests/browser/browser_accessibility_keyboard_audit.js! (edit, then use 'hg resolve --mark')
warning: conflicts while merging devtools/server/tests/browser/doc_accessibility_keyboard_audit.html! (edit, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue

Edit: Nevermind it worked.

Comment 16

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/ce4d6d3f06be
https://hg.mozilla.org/releases/mozilla-beta/rev/a063c314523c
https://hg.mozilla.org/releases/mozilla-beta/rev/dc043d2b3346
https://hg.mozilla.org/releases/mozilla-beta/rev/478dc85c8256
https://hg.mozilla.org/releases/mozilla-beta/rev/8e115a255dfa
https://hg.mozilla.org/releases/mozilla-beta/rev/12c12e936df1