Closed Bug 1578513 Opened 2 years ago Closed 1 year ago

disabling/uninstalling extension in safe-mode leaks settings/prefs

Categories

(WebExtensions :: General, defect, P1)

defect

Tracking

(firefox72 verified, firefox73 verified)

VERIFIED FIXED
mozilla72
Tracking Status
firefox72 --- verified
firefox73 --- verified

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

(Blocks 1 open bug)

Details

Attachments

(2 files, 1 obsolete file)

If you restart in safe mode then disable or uninstall an extension, ExtensionSettings and ExtensionPreferencesManager do not update/remove any settings.

Can you give the patches here a look over? I haven't written up tests yet, but have a solid manual str. The uninstall works great. The issue with the disable is that we need to somehow support enable, so I haven't gone further down that road yet.

Flags: needinfo?(andrew.swan)

commented on phabricator

Flags: needinfo?(andrew.swan)
Attachment #9090266 - Attachment description: Bug 1578513 make disable during safemode remove extension settings → Bug 1578513 make disable/enable during safe mode update extension settings
Blocks: 1580240

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(jmathies)
Assignee: nobody → mixedpuppy
Flags: needinfo?(jmathies)
Priority: -- → P1

Comment on attachment 9090812 [details]
Bug 1578513 disable all extension settings in safemode

Revision D44886 was moved to bug 1586543. Setting attachment 9090812 [details] to obsolete.

Attachment #9090812 - Attachment is obsolete: true
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b2a4d2f3e995
make uninstall during safemode remove extension settings r=robwu
https://hg.mozilla.org/integration/autoland/rev/7c92eb8c4979
make disable/enable during safe mode update extension settings r=robwu
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla72

Hello,

In order to verify this ticket I've tested the following STR:

  1. Launch browser and install https://addons.mozilla.org/en-US/firefox/addon/new-tab-override/ extension.
  2. In about:config three new preferences have been added when searching for using the "newtab" keyword:
    extensions.webextensions.ExtensionStorageIDB.migrated.newtaboverride@agenedia.com
    browser.newtab.extensionControlled
    browser.newtab.privateAllowed
  3. Go to About:support and click on the "Restart with Add-ons Disabled" option.
  4. After restart verify that newtab preferences are still listed in about:config.
  5. Either from Addons Manager (where all addons have been disabled) or from AMO remove the extension.
  6. Restart the browser and check that the preferences from point 2 have been removed.

Note that the preferences are not removed after about:config refresh when the extension is uninstalled in safe mode, until after restart.

Tested on Windows Pro 10 64-bit, Ubuntu 18.03.4 LTS and macOS Catalina 10.15 on FF Beta 72.0b4 (20191206183317) and Ff Nightly 73.0a1 (20191209215019).

Is there another scenario that should be verified, to check other settings are updated/ removed?

Flags: needinfo?(mixedpuppy)

(In reply to Miruna Curtean from comment #11)

Note that the preferences are not removed after about:config refresh when the extension is uninstalled in safe mode, until after restart.

If you're uninstalling from about:addons, you may need to refresh about:addons before the uninstall takes effect. The preferences should be reset at that point, without a restart.

Flags: needinfo?(mixedpuppy) → needinfo?(mcurtean)

If you're uninstalling from about:addons, you may need to refresh about:addons before the uninstall takes effect. The preferences should be reset at that point, without a restart.

Indeed they are. Thank you for the tip.
I've verified that as well on Windows Pro 10 64-bit, Ubuntu 18.03.4 LTS and macOS Catalina 10.15 on FF Beta 72.0b5 (20191210230245) and FF Nightly 73.0a1 (20191211214629) and am marking this issue as verified fixed.

Status: RESOLVED → VERIFIED
Flags: needinfo?(mcurtean)
Regressions: 1638888
You need to log in before you can comment on or make changes to this bug.