1578513 - disabling/uninstalling extension in safe-mode leaks settings/prefs

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P1)

Description

[Shane Caraveo (:mixedpuppy)]

If you restart in safe mode then disable or uninstall an extension, ExtensionSettings and ExtensionPreferencesManager do not update/remove any settings.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1578513 make uninstall during safemode remove extension settings

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1578513 make disable/enable during safe mode update extension settings

Comment 3

[Shane Caraveo (:mixedpuppy)]

Can you give the patches here a look over? I haven't written up tests yet, but have a solid manual str. The uninstall works great. The issue with the disable is that we need to somehow support enable, so I haven't gone further down that road yet.

Comment 4

[Andrew Swan [:aswan]]

commented on phabricator

Comment 5

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1578513 disable all extension settings in safemode

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 7

[Phabricator Automation]

Comment on attachment 9090812 [details]
Bug 1578513 disable all extension settings in safemode

Revision D44886 was moved to bug 1586543. Setting attachment 9090812 [details] to obsolete.

Comment 8

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a02662fdc3c56e34bd76b281eb632b1ff314d8d8

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2a4d2f3e995
make uninstall during safemode remove extension settings r=robwu
https://hg.mozilla.org/integration/autoland/rev/7c92eb8c4979
make disable/enable during safe mode update extension settings r=robwu

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b2a4d2f3e995
https://hg.mozilla.org/mozilla-central/rev/7c92eb8c4979

Comment 11

[Miruna Curtean]

Hello,

In order to verify this ticket I've tested the following STR:

1. Launch browser and install https://addons.mozilla.org/en-US/firefox/addon/new-tab-override/ extension.
2. In about:config three new preferences have been added when searching for using the "newtab" keyword:
   exte[e-mail]
   browser.newtab.extensionControlled
   browser.newtab.privateAllowed
3. Go to About:support and click on the "Restart with Add-ons Disabled" option.
4. After restart verify that newtab preferences are still listed in about:config.
5. Either from Addons Manager (where all addons have been disabled) or from AMO remove the extension.
6. Restart the browser and check that the preferences from point 2 have been removed.

Note that the preferences are not removed after about:config refresh when the extension is uninstalled in safe mode, until after restart.

Tested on Windows Pro 10 64-bit, Ubuntu 18.03.4 LTS and macOS Catalina 10.15 on FF Beta 72.0b4 (20191206183317) and Ff Nightly 73.0a1 (20191209215019).

Is there another scenario that should be verified, to check other settings are updated/ removed?

Comment 12

[Shane Caraveo (:mixedpuppy)]

(In reply to Miruna Curtean from comment #11)

Note that the preferences are not removed after about:config refresh when the extension is uninstalled in safe mode, until after restart.

If you're uninstalling from about:addons, you may need to refresh about:addons before the uninstall takes effect. The preferences should be reset at that point, without a restart.

Comment 13

[Miruna Curtean]

If you're uninstalling from about:addons, you may need to refresh about:addons before the uninstall takes effect. The preferences should be reset at that point, without a restart.

Indeed they are. Thank you for the tip.
I've verified that as well on Windows Pro 10 64-bit, Ubuntu 18.03.4 LTS and macOS Catalina 10.15 on FF Beta 72.0b5 (20191210230245) and FF Nightly 73.0a1 (20191211214629) and am marking this issue as verified fixed.