Closed
Bug 1578544
Opened 5 years ago
Closed 5 years ago
[Protection Report] Margins and height adjustments
Categories
(Firefox :: Protections UI, enhancement, P1)
Tracking
()
RESOLVED
FIXED
Firefox 71
People
(Reporter: ewright, Assigned: ewright)
References
Details
(Whiteboard: [protection-report][skyline])
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-beta+
|
Details | Review |
Some margins and heights should be adjusted.
- Smaller margin on the top of the page
- larger margin at the bottom of the page
- graph section should be shorter
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Whiteboard: [protection-report] → [protection-report][skyline]
Updated•5 years ago
|
Attachment #9090176 -
Attachment description: Bug 1578544 - Resize margins and heeights. → Bug 1578544 - Resize margins and heights.
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/02b084edc698
Resize margins and heights. r=johannh
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Assignee | ||
Comment 4•5 years ago
|
||
Comment on attachment 9090176 [details]
Bug 1578544 - Resize margins and heights.
Beta/Release Uplift Approval Request
- User impact if declined: Visuals for protection report not as desired.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple CSS patch changing some margins and height.
- String changes made/needed: none
Attachment #9090176 -
Flags: approval-mozilla-beta?
Comment 5•5 years ago
|
||
Comment on attachment 9090176 [details]
Bug 1578544 - Resize margins and heights.
CSS fix for feature we're shipping in 70, ok for uplift for beta 5.
Attachment #9090176 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•5 years ago
|
||
bugherder uplift |
status-firefox70:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•