1578557 - Remove "eslint-disable" sections from ComposerCommands.js

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, task, P3)

Description

[Paul Morris [:pmorris]]

The ComposerCommands.js file has several "eslint-disable" sections, but there doesn't seem to be any reason for them. Remove them and reformat the file with Prettier.

This is part of the work of bug 1572047. The other uses of "eslint-disable" comments in comm/ code appear to be needed whereas these don't.

(Note mkmelin says this file is going away soon, with relevant parts being moved under the mail/ directory. I had just done the work to fix this when I found out about this plan.)

Comment 1

[Paul Morris [:pmorris]]

Attachment: remove-eslint-disable-comments-0.patch

Remove the "eslint-disable" sections, reformat using Prettier, then fix remaining eslint issues.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9090183 [details] [diff] [review]
remove-eslint-disable-comments-0.patch

Review of attachment 9090183 [details] [diff] [review]:
-----------------------------------------------------------------

Sure. r=mkmelin

Comment 3

[Jorg K (CEST = GMT+2)]

Comment on attachment 9090183 [details] [diff] [review]
remove-eslint-disable-comments-0.patch

That should join the other prettier stuff on beta, right?

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a2b37e328ee0
Remove unneeded "eslint-disable" comments in editor's ComposerCommands.js. r=mkmelin DONTBUILD

Comment 5

[Paul Morris [:pmorris]]

(In reply to Jorg K (GMT+2) from comment #3)

That should join the other prettier stuff on beta, right?

Yes, thanks.

Comment 6

[Jorg K (CEST = GMT+2)]

TB 70 beta 1:
https://hg.mozilla.org/releases/comm-beta/rev/5954a0926ac11c1b55e8a4e49b360bd955d2a842