1578569 - Padding is wrong in bookmarks popup for some submenus

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Brian Grinstead [:bgrins]]

I re-added a CSS rule in Bug 1573158 to handle overflowing menus (https://hg.mozilla.org/integration/autoland/rev/3f54e52c52eb#l2.12) but now I notice that causes some vertical misalignment for some non-overflowing submenus.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: last-item-clipped.png

Comment 2

[Brian Grinstead [:bgrins]]

Attachment: padding-only-at-top.png

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Bug 1578569 - Restore padding-bottom on certain menupopups inside BMB_bookmarksPopup

This was removed in Bug 1573158, where the following line change forced it to 0px:
https://hg.mozilla.org/integration/autoland/rev/3f54e52c52eb#l2.12

This uses shadow parts instead of Shadow DOM + XBL selectors into the arrowscrollbox,
which unblocks arrowscrollbox Custom Element conversion and appears to have the same
visual effect as far as I can tell.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2b5a403990b1
Restore padding-bottom on certain menupopups inside BMB_bookmarksPopup r=mak

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2b5a403990b1

Comment 6

[Negritas Sergiu, Desktop QA]

I did not manage to reproduce the issue using Fx 71.0a1 (2019-09-02). Can you verify that the issue is fixed? http://archive.mozilla.org/pub/devedition/candidates/71.0b11-candidates/build1/

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to Negritas Sergiu from comment #6)

I did not manage to reproduce the issue using Fx 71.0a1 (2019-09-02). Can you verify that the issue is fixed? http://archive.mozilla.org/pub/devedition/candidates/71.0b11-candidates/build1/

Should be fixed in 71, yes. Marking as verified.

Comment 8

[Negritas Sergiu, Desktop QA]

Thank you for the response I will clear the remaining flags.