1578575 - Ad Privacy Info Frontend

Status: VERIFIED FIXED

(Firefox :: New Tab Page, task, P1)

Description

[Wolasi :wolasi]

• Add “Our sponsors & your privacy” prompt to Context menu for Ads
• Clicking on the prompt should display a modal that explains that ads are vetted and private
• Privacy info modal should use the same scrip and positioning as the Add Top Site modal
• Copy for modal is in the spec
• Privacy info link: https://www.mozilla.org/en-US/privacy/firefox/

Design Spec
https://www.figma.com/file/qyNzY5j5kj8gYWmE2Yeb28/New-Tab-Spec-for-Fx-71?node-id=29%3A1

Figma Prototype
https://www.figma.com/proto/qyNzY5j5kj8gYWmE2Yeb28/New-Tab-Spec-for-Fx-71?node-id=30%3A0&viewport=19%2C325%2C0.25&scaling=min-zoom

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5325

Comment 2

[Gavin Suntop [:gvn] (they/them)]

@Wolasi Here's a build for you to design review:

https://queue.taskcluster.net/v1/task/d9e66l6gRqigbpJCUJFXdQ/runs/0/artifacts/public/build/target.dmg

Comment 3

[Wolasi :wolasi]

@gvn Looking good! Only feedback is the width of the modal. It should match the other modals, but not a blocker.

Comment 4

[Gavin Suntop [:gvn] (they/them)]

Great! We can look into width as part of the overall modal styling ticket follow-on. The top sites modal is actually overriding the default of 960px, so we can look into consolidating them and maybe changing the default width.

I'll move into code review.

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/be0251572777

Comment 6

[Andreea Cupsa [:acupsa], Experiments QA]

I have verified this issue on Latest Firefox Nightly 71.0a1 (Build ID: 20191007215350) on Windows 10 x64, Mac 10.14.6 and Arch Linux 4.16.6 x64.
The “Our sponsors & your privacy” modal is displayed after clicking the “Our sponsors & your privacy” option from the context menu of a Recommended by Pocket card.