Closed Bug 1578575 Opened 3 months ago Closed 2 months ago

Ad Privacy Info Frontend

Categories

(Firefox :: New Tab Page, task, P1)

task

Tracking

()

VERIFIED FIXED
Firefox 71
Iteration:
71.3 - Sept 30 - Oct 13
Tracking Status
firefox71 --- verified

People

(Reporter: wolasi, Assigned: gsuntop)

References

(Blocks 2 open bugs)

Details

(Keywords: github-merged)

Attachments

(1 file)

  • Add “Our sponsors & your privacy” prompt to Context menu for Ads
  • Clicking on the prompt should display a modal that explains that ads are vetted and private
  • Privacy info modal should use the same scrip and positioning as the Add Top Site modal
  • Copy for modal is in the spec
  • Privacy info link: https://www.mozilla.org/en-US/privacy/firefox/

Design Spec
https://www.figma.com/file/qyNzY5j5kj8gYWmE2Yeb28/New-Tab-Spec-for-Fx-71?node-id=29%3A1

Figma Prototype
https://www.figma.com/proto/qyNzY5j5kj8gYWmE2Yeb28/New-Tab-Spec-for-Fx-71?node-id=30%3A0&viewport=19%2C325%2C0.25&scaling=min-zoom

Assignee: nobody → gsuntop
Iteration: --- → 71.1 - Sept 2 - 15
Priority: -- → P1
Iteration: 71.1 - Sept 2 - 15 → 71.2 - Sept 16 - 29
Flags: needinfo?(wkonu)

@gvn Looking good! Only feedback is the width of the modal. It should match the other modals, but not a blocker.

Flags: needinfo?(wkonu)

Great! We can look into width as part of the overall modal styling ticket follow-on. The top sites modal is actually overriding the default of 960px, so we can look into consolidating them and maybe changing the default width.

I'll move into code review.

Iteration: 71.2 - Sept 16 - 29 → 71.3 - Sept 30 - Oct 13
Blocks: 1586093
Status: NEW → RESOLVED
Closed: 2 months ago
Keywords: github-merged
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

I have verified this issue on Latest Firefox Nightly 71.0a1 (Build ID: 20191007215350) on Windows 10 x64, Mac 10.14.6 and Arch Linux 4.16.6 x64.
The “Our sponsors & your privacy” modal is displayed after clicking the “Our sponsors & your privacy” option from the context menu of a Recommended by Pocket card.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.