1578614 - Change Fennec about:addons' AMO URL from "firefox" to "android"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Add-on Manager, enhancement, P1)

Description

[Chris Peterson [:cpeterson]]

The AMO team asked that we change Fennec's about:addons' AMO URL (the extensions.getAddons.browseAddons pref) to specify android instead of firefox like:

-pref("extensions.getAddons.browseAddons", "https://addons.mozilla.org/%LOCALE%/firefox/collections/4757633/mob/?page=1&collection_sort=-popularity");
+pref("extensions.getAddons.browseAddons", "https://addons.mozilla.org/%LOCALE%/android/collections/4757633/mob/?page=1&collection_sort=-popularity");

Using firefox in the URL causes two problems:

1. The firefox AMO page will include "Recommended" badges. Apparently that badge is something the AMO team only wants to show to desktop Firefox users. I don't know why, but it's easy for us to fix. :)
2. The firefox AMO page includes links that allow the Fennec user to inadvertently browse to AMO pages intended for desktop Firefox users.

TBD: I am checking whether the AMO team also wants us to change Fennec's about:addons' AMO link title from Browse Firefox's Recommended Extensions to Browse Firefox's Featured Extensions. The link loads an AMO page called "Featured extensions for Android" and the AMO team doesn't want to show the "Recommended" badge to Fennec users, so perhaps we should also avoid the word "Recommended" in Fennec's about:addons.

Comment 1

[athomas]

Let's just change the URL for now

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1578614 - Change Fennec about:addons' AMO URL from "firefox" to "android"; r?VladBaicu

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc6b987ba5bf
Change Fennec about:addons' AMO URL from "firefox" to "android"; r=VladBaicu

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/dc6b987ba5bf

Comment 5

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9090601 [details]
Bug 1578614 - Change Fennec about:addons' AMO URL from "firefox" to "android"; r?VladBaicu

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Change requested by the AMO team for the next release.
• User impact if declined: Users would not get the optimal experience for Fennec.
• Fix Landed on Version: 71
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One URL changed.
• String or UUID changes made by this patch:

Comment 6

[Diana Rus]

Hi, verified as fixed with Samsung Galaxy Note 9(Android 8.1.0) and Google Pixel(Android Q) on Firefox Nightly 71.0a1(2019-09-06) for the change applied through comment 3.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9090601 [details]
Bug 1578614 - Change Fennec about:addons' AMO URL from "firefox" to "android"; r?VladBaicu

Small AMO link change. Approved for Fennec 68.2b2.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr68/rev/37ec6a002816

Comment 9

[Chris Peterson [:cpeterson]]

Adding [fennec68.2] whiteboard tag because we can let this AMO URL fix ride in Fennec ESR 68.2 (October 21). There is no urgency to ship this fix in a 68.1.x dot release, though it would be a safe ride-along.

Comment 10

[Diana Rus]

Hi, verified as fixed with Google Pixel 3 XL (Android 9), Samsung Galaxy Note 9 (Android 8.1.0) and Sony Xperia Z5 (Android 7.0) on Firefox Beta 68.2b2 - as per comment 7.
Will leave the ticket in this state until verification on Firefox RC 68.2 - as per comment 9.

Comment 11

[Diana Rus]

Hi, verified as fixed with Galaxy Samsung Tab A (Android 9.0), Google Pixel 3 XL(Android 9) and Sony Xperia Z5 (Android 7.0) on Firefox Release 68.2.0
Video with fix available.
I will mark the ticket as VERIFIED.