Closed Bug 1578634 Opened 5 years ago Closed 3 years ago

White line on top of windows in latest nightly on MacOS

Categories

(Core :: Widget: Cocoa, defect, P3)

71 Branch
defect

Tracking

()

RESOLVED DUPLICATE of bug 1575070

People

(Reporter: thomas.werner, Unassigned)

References

Details

Attachments

(5 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:69.0) Gecko/20100101 Firefox/69.0

Steps to reproduce:

Updated to 70/71 Firefox Nightly.

Actual results:

Seems that Firefox 70/71 makes now the same like other apps in macOS if the OS uses light mode but Firefox a dark theme. Firefox now shows an ugly white line on top of windows.

Expected results:

In Firefox 69 its still nice (see attachment)

+1 That white line is horrible, and those rounded corners too. Firefox 69 is perfect in that regard.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Theme

This is the same with dark themes in chromium browsers. It's really annoying, especially with dark backgrounds.

Component: Theme → Widget: Cocoa
Product: Firefox → Core

We seem to be conforming to the macOS behavior (since other apps exhibit the same behavior) and are unlikely to work around it.

Status: UNCONFIRMED → RESOLVED
Closed: 5 years ago
Resolution: --- → INVALID

Everything is true that it is a typical issue under current macOS. But i was happy that Firefox was not affected (until now). Whatever the reason was or whatever Mozilla did to make dark themes looking great, any chance to restore the previous "workaround"?

Btw. if this is a typically macOS behavior why the borders are different if i switch to dark in macOS? For me it looks this is an issue in Firefox. Does Firefox really switch to dark (see new screenshot)?

The white line is caused by the Aqua appearance being forced. When you turn off the NSRequiresAquaSystemAppearance key, the issue disappears. I suggest reopening this bug.

See Also: → 1670710

As you can see, there is a white line visible when NSRequiresAquaSystemAppearance is set to true.

The white line isn't visible when NSRequiresAquaSystemAppearance is set to false. This is why I suggest reopening the bug. :)

I apologize for the spam, but just to clarify: these screenshots were taken when the system was in dark mode. The plist editor app I use (ProperTree) does not have a dark mode, please disregard its state.

Much much better, it fixes the issue with the edges as well. Now the upper white line has a much lower contrast and the ones in the corners and sides a bit more like other "native" apps. Sorry for the extra screenshot but i want to be sure that this bug is not ignored anymore and I hope it finds its way into next release.

Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: INVALID → ---

(In reply to Thomas Werner from comment #11)

Created attachment 9183395 [details]
Screenshot 2020-10-23 at 09.53.55.png

Much much better, it fixes the issue with the edges as well. Now the upper white line has a much lower contrast and the ones in the corners and sides a bit more like other "native" apps. Sorry for the extra screenshot but i want to be sure that this bug is not ignored anymore and I hope it finds its way into next release.

I'd really, really love for that to happen, but the truth is that Firefox is not ready for true macOS dark mode yet. Last time I checked, the library, context menus, windows, etc. were broken in dark mode. That is why system light mode is forced through that key in Info.plist (which causes the white line, among other things). It will probably take a while longer.

(In reply to Alexei Solonari from comment #12)

(In reply to Thomas Werner from comment #11)

Created attachment 9183395 [details]
Screenshot 2020-10-23 at 09.53.55.png

Much much better, it fixes the issue with the edges as well. Now the upper white line has a much lower contrast and the ones in the corners and sides a bit more like other "native" apps. Sorry for the extra screenshot but i want to be sure that this bug is not ignored anymore and I hope it finds its way into next release.

I'd really, really love for that to happen, but the truth is that Firefox is not ready for true macOS dark mode yet. Last time I checked, the library, context menus, windows, etc. were broken in dark mode. That is why system light mode is forced through that key in Info.plist (which causes the white line, among other things). It will probably take a while longer.

You're correct. In order for this key to be removed bug 1623686 will need to be fixed first. I've added the dependency.

Depends on: 1623686
Severity: normal → S3
Priority: -- → P3
Blocks: 1700211
No longer blocks: 1700211
Status: REOPENED → RESOLVED
Closed: 5 years ago3 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: