Closed
Bug 1578668
Opened 5 years ago
Closed 5 years ago
Simplify more code around `nsPlainTextSerializer::EndLine`
Categories
(Core :: DOM: Serializers, enhancement)
Core
DOM: Serializers
Tracking
()
RESOLVED
FIXED
mozilla71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: mbrodesser-Igalia, Assigned: mbrodesser-Igalia)
Details
Attachments
(6 files)
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review | |
|
47 bytes,
text/x-phabricator-request
|
Details | Review |
No description provided.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → mbrodesser
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D44650
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D44651
|
|
Assignee | |
Comment 4•5 years ago
|
||
Depends on D44652
|
|
Assignee | |
Comment 5•5 years ago
|
||
Depends on D44653
|
|
Assignee | |
Comment 6•5 years ago
|
||
To remove the obscurity of the conditions.
Depends on D44654
Pushed by mbrodesser@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/988093895b44 part 1) Remove some code redundancy in `nsPlainTextSerializer::EndLine`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/75b65888a4b5 part 2) Move `nsPlainTextSerializer::FlushLine` to `nsPlainTextSerializer::OutputManager::Flush`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/067c257a5294 part 3) Add `IsSignatureSeparator`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/dc4b3abf0d58 part 4) Factor out `CreateLineOfDashes`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/4dad1ee46933 part 5) Add `CurrentLine::HasContentOrIndentationHeader`. r=hsivonen https://hg.mozilla.org/integration/autoland/rev/ca9fa19ab9a1 part 6) Reorder conditions using `mHasWrittenCellsForRow`. r=hsivonen
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/988093895b44
https://hg.mozilla.org/mozilla-central/rev/75b65888a4b5
https://hg.mozilla.org/mozilla-central/rev/067c257a5294
https://hg.mozilla.org/mozilla-central/rev/dc4b3abf0d58
https://hg.mozilla.org/mozilla-central/rev/4dad1ee46933
https://hg.mozilla.org/mozilla-central/rev/ca9fa19ab9a1
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in
before you can comment on or make changes to this bug.
Description
•