1578690 - Crash in [@ mozilla::MozPromise<T>::ThenValueBase::AssertIsDead]

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-a61f777c-1a77-4e43-8ec9-a2e3d0190903.

Top 10 frames of crashing thread:

0 xul.dll void mozilla::MozPromise<DiskInfo, nsresult, 0>::ThenValueBase::AssertIsDead xpcom/threads/MozPromise.h:435
1 xul.dll void mozilla::MozPromise<mozilla::dom::ClientSourceParent*, nsresult, 0>::AssertIsDead xpcom/threads/MozPromise.h:966
2 xul.dll void mozilla::MozPromise<mozilla::dom::ClientSourceParent*, nsresult, 0>::~MozPromise xpcom/threads/MozPromise.h:1007
3 xul.dll static void mozilla::MozPromise<mozilla::dom::ClientSourceParent*, nsresult, 0>::Private::~Private xpcom/threads/MozPromise.h:246
4 xul.dll class RefPtr<mozilla::MozPromise<mozilla::dom::ClientSourceParent*, nsresult, 0> > mozilla::dom::ClientHandleParent::EnsureSource dom/clients/manager/ClientHandleParent.cpp:82
5 xul.dll void mozilla::dom::ClientHandleOpParent::Init dom/clients/manager/ClientHandleOpParent.cpp:28
6 xul.dll class mozilla::ipc::IPCResult mozilla::dom::ClientHandleParent::RecvPClientHandleOpConstructor dom/clients/manager/ClientHandleParent.cpp:52
7 xul.dll mozilla::dom::PClientHandleParent::OnMessageReceived ipc/ipdl/PClientHandleParent.cpp:262
8 xul.dll mozilla::ipc::PBackgroundParent::OnMessageReceived ipc/ipdl/PBackgroundParent.cpp:3588
9 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2107

There are 4 crashes (from 3 installations) in nightly 71 with buildid 20190903094847. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1556489.

[1] https://hg.mozilla.org/mozilla-central/rev?node=6125bb02952a

Comment 1

[Pascal Chevrel:pascalc (PTO until April 26)]

Nhi could we get this bug triaged please? Thanks

Comment 2

[Nhi Nguyen (:nhi)]

ni Valentin to triage

Comment 3

[Valentin Gosu [:valentin] (he/him)]

The code for ClientHandleParent::EnsureSource was touched in bug 1556489.
Matt, do you have time to take a look?

Comment 4

[Neha Kochar [:neha]]

Matt or Jean-Yves would be appropriate to look into this.

Comment 5

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1578690 - Only create a new promise in EnsureSource if we didn't already have one. r?Perry

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd31644a04d5
Only create a new promise in EnsureSource if we didn't already have one. r=perry

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/dd31644a04d5

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/dd31644a04d5